-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow creating tables with avro.schema.literal #14426
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: weijiii.
|
Signed CLA sent via email. |
I thought we support avro schema literals for years. cc @anusudarsan |
@weijiii can you suggest a more descriptive PR title? |
@findepi The first commit is to make The second commit is to allow Trino to use I'd like to keep this PR for adding support for |
|
5a29c93
to
547db5a
Compare
82008a7
to
0d4405e
Compare
Previously failed test case |
Failed test:
Test detail:
Re-run succeeds locally with:
I think it is unrelated to this patch. The error message indicates credential expiration, possibly due to test running overtime? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phd3 do you want to take a look?
plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveMetadata.java
Outdated
Show resolved
Hide resolved
...ing/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestAvroSchemaLiteral.java
Outdated
Show resolved
Hide resolved
dac71b7
to
0ba244b
Compare
(just squashed, the build was green https://github.com/trinodb/trino/actions/runs/3293963286) |
Description
This PR aims to address the following
avro.schema.literal
.avro.schema.literal
and querying from Trino (TestAvroSchemaLiteral
)avro.schema.literal
and querying from Trino (TestAvroSchemaLiteral
)avro.schema.literal
(Captured inBaseTestAvroSchemaEvolution
)Update also needed in https://github.com/trinodb/trino/blob/master/docs/src/main/sphinx/connector/hive.rst
Non-technical explanation
With this change, Trino users will be able to create Hive table using
avro.schema.literal
to define the schema.Release notes
( ) This is not user-visible or docs only and no release notes are required.
(x) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: