Allow fetching file based access provider rules via http(s) url #14008

arkadiuszbalcerek · 2022-09-06T12:41:40Z

Description

This is actually replacement for #11491
The changes are integrated with the newest trino code
New fork created as we don't have write permission to https://github.com/clemensvonschwerin/presto/tree/file-system-based-access-provider-via-rest
Would like to move it forward and finally get merged to official trino codebase

Is this change a fix, improvement, new feature, refactoring, or other?

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

How would you describe this change to a non-technical end user or system administrator?

Related issues, pull requests, and links

Documentation

( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
(x) Release notes entries required with the following suggested text:

# Security
* Allow fetching access control rules via http(s) url

cla-bot · 2022-09-06T12:41:41Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

arkadiuszbalcerek · 2022-09-06T12:47:07Z

Hi @kokosing,
This PR is replacement for #11491
It is integrated with the newest trino and some adjustments are done. Could you please trigger the checks and review it?

kokosing · 2022-09-06T14:42:11Z

@Praveen2112 Would you like to do a review?

Praveen2112 · 2022-09-06T14:42:42Z

Will take a look at it

cla-bot · 2022-09-07T06:05:51Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

arkadiuszbalcerek · 2022-09-07T09:49:18Z

Hi @kokosing @Praveen2112 I fixed some tests so all checks except plugin/trino-elasticsearch succeeded. plugin/trino-elasticsearch got cancelled (due to exceeding the timeout I guess) but I don't think it is related to changes in this PR (previous run succeeded). Please review and give us some feedback what else should be improved to get this merged

Praveen2112

Instead of reusing FileBasedAccessControl - can we have a generic Connector/System Access Control based on JsonRules and have different ways of injecting rules from a file or from a URI (with a specific start point).

lib/trino-plugin-toolkit/pom.xml

Praveen2112 · 2022-09-08T09:22:48Z

...trino-plugin-toolkit/src/main/java/io/trino/plugin/base/security/FileBasedAccessControl.java

@@ -106,12 +105,12 @@
    private final List<SessionPropertyAccessControlRule> sessionPropertyRules;
    private final Set<AnySchemaPermissionsRule> anySchemaPermissionsRules;

-    public FileBasedAccessControl(CatalogName catalogName, File configFile)
+    public FileBasedAccessControl(CatalogName catalogName, Supplier<AccessControlRules> rulesProvider)


Can we have a different AccessControl implementation if they are fetched from REST APIs or maybe we could have a generic JsonBasedAccessControl and rules can be injected from a file or a remote hosted file or using some endpoints. WDYT ?

...-plugin-toolkit/src/main/java/io/trino/plugin/base/security/FileBasedAccessControlUtils.java

...plugin-toolkit/src/main/java/io/trino/plugin/base/security/FileBasedAccessControlModule.java

plugin/trino-atop/src/main/java/io/trino/plugin/atop/AtopConnectorFactory.java

cla-bot · 2022-09-12T08:05:18Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2022-09-12T10:12:45Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2022-09-12T12:27:03Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Praveen2112

Can you squash the commits. We could have one for preparatory changes and one with the actual set of changes.

Praveen2112 · 2022-09-12T13:17:09Z

...trino-plugin-toolkit/src/main/java/io/trino/plugin/base/security/FileBasedAccessControl.java

@@ -104,12 +103,12 @@
    private final List<SessionPropertyAccessControlRule> sessionPropertyRules;
    private final Set<AnySchemaPermissionsRule> anySchemaPermissionsRules;

-    public FileBasedAccessControl(CatalogName catalogName, File configFile)
+    public FileBasedAccessControl(CatalogName catalogName, Supplier<AccessControlRules> rulesProvider)


Can we rename it as JsonAccessControl or something ?

cc: @kokosing Any good names we can use here ?

You mean rename the file/class? We have a few classes starting with FileBasedAccessControl? Do you want to rename all of them?

Since we inject the AccessControlRules I guess FileBasedAccessControl makes less sense here. WDYT ?

refactored - renamed to RulesBasedAccessControl

Praveen2112 · 2022-09-12T13:17:54Z

...trino-plugin-toolkit/src/main/java/io/trino/plugin/base/security/FileBasedAccessControl.java

    {
        this.catalogName = catalogName.toString();

-        AccessControlRules rules = parseJson(configFile.toPath(), AccessControlRules.class);
-        checkArgument(!rules.hasRoleRules(), "File connector access control does not support role rules: %s", configFile);
+        AccessControlRules rules = rulesProvider.get();


requireNonNull check for supplier ? Any specific reason for supplier ? Can we inject AccessControlRules directly ?

Praveen2112 · 2022-09-12T13:19:24Z

...plugin-toolkit/src/main/java/io/trino/plugin/base/security/FileBasedAccessControlConfig.java

    }

    @Config(SECURITY_CONFIG_FILE)
-    public FileBasedAccessControlConfig setConfigFile(File configFile)
+    public FileBasedAccessControlConfig setConfigFilePath(String configFilePath)


Can we have it as a part of preparatory commit ?

I squashed to two commits. Unfortunately this one went to the second one. I won't be able now to extract it and squash other way. If this is a problem I can create another PR with this one as initial commit

...plugin-toolkit/src/main/java/io/trino/plugin/base/security/FileBasedAccessControlConfig.java

Praveen2112 · 2022-09-12T13:22:54Z

...plugin-toolkit/src/main/java/io/trino/plugin/base/security/FileBasedAccessControlConfig.java

@@ -56,4 +69,9 @@ public FileBasedAccessControlConfig setRefreshPeriod(Duration refreshPeriod)
        this.refreshPeriod = refreshPeriod;
        return this;
    }
+
+    public boolean isRest()


Instead of checking if it a file or a REST url ? Can we have have some enum which could be configured so we could have dedicated set of properties for each type.

cla-bot · 2022-09-13T08:42:50Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2022-09-13T11:01:07Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2022-09-13T11:22:33Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

AdrianSkierniewski · 2022-10-24T11:32:49Z

Hi Guys,

The work on this PR has been dragging on for several months. We already invested quite some time and resources to constantly rebase. We're following the same pattern that it's already used in other places when you can configure refresh via HTTP request. An example bellow:

The configuration JSON can either be retrieved from a file or REST-endpoint specified via hive.s3.security-mapping.config-file.

https://trino.io/docs/current/connector/hive-s3.html?highlight=iam#s3-security-mapping

We're really grateful Trino community for a such amazing piece of software, so please don't get me wrong. It feels really unproductive on our side to constantly invest more time on the PR and engage in endless discussions.

@Praveen2112 @kokosing could you help us with merging this one?

Praveen2112

Sorry for the delay. Thanks for working on this and we really appreciate your effort this PR, we do have a minor concerns which we have specified. Do let us know if there are any issues in applying them.

Praveen2112 · 2022-10-24T13:40:03Z

lib/trino-plugin-toolkit/pom.xml

+        <dependency>
+            <groupId>io.airlift</groupId>
+            <artifactId>http-client</artifactId>
+            <exclusions>


Why do we have to exclude them ? Can we provide a comment here - does the versions conflict ?

io.airlift.node is needed only for tests. If not excluded here dependency-scope-maven-plugin will complain

Where do we use them in tests ?

Instead of excluding this - Can we add node as a rutime dependency

 <dependency> <groupId>io.airlift</groupId> <artifactId>node</artifactId> <scope>runtime</scope> </dependency>

Praveen2112 · 2022-10-24T13:41:07Z

...trino-plugin-toolkit/src/main/java/io/trino/plugin/base/security/FileBasedAccessControl.java

@@ -104,12 +103,12 @@
    private final List<SessionPropertyAccessControlRule> sessionPropertyRules;
    private final Set<AnySchemaPermissionsRule> anySchemaPermissionsRules;

-    public FileBasedAccessControl(CatalogName catalogName, File configFile)
+    public FileBasedAccessControl(CatalogName catalogName, Supplier<AccessControlRules> rulesProvider)


Since we inject the AccessControlRules I guess FileBasedAccessControl makes less sense here. WDYT ?

Praveen2112 · 2022-10-24T13:41:23Z

...trino-plugin-toolkit/src/main/java/io/trino/plugin/base/security/FileBasedAccessControl.java

    {
        this.catalogName = catalogName.toString();

-        AccessControlRules rules = parseJson(configFile.toPath(), AccessControlRules.class);
-        checkArgument(!rules.hasRoleRules(), "File connector access control does not support role rules: %s", configFile);
+        AccessControlRules rules = rulesProvider.get();


Praveen2112 · 2022-10-24T13:47:33Z

...plugin-toolkit/src/main/java/io/trino/plugin/base/security/FileBasedAccessControlModule.java

+                            .in(Scopes.SINGLETON);
+                    httpClientBinder(innerBinder).bindHttpClient("security-http-client", ForAccessControlRules.class)
+                            .withConfigDefaults(config -> config
+                                    .setRequestTimeout(Duration.succinctDuration(10, TimeUnit.SECONDS))


~~Any specific reason for setting this configuration to 10s. We could also cofigure them via http-client config if required ?~~

Mentioned here - #6210 (comment)

Praveen2112 · 2022-10-24T13:51:01Z

...-plugin-toolkit/src/main/java/io/trino/plugin/base/security/FileBasedAccessControlUtils.java

+    {
+    }
+
+    public static <R> R parseJSONString(String jsonString, String jsonPointer, Class<R> clazz)


Instead of a static method, can we have something like a parser (S3SecurityMappingsParser)

refactored - this util doesn't exist any more

Praveen2112 · 2022-10-24T14:25:05Z

...plugin-toolkit/src/main/java/io/trino/plugin/base/security/FileBasedAccessControlModule.java

+                config -> !config.isRest(),
+                innerBinder -> {
+                    innerBinder.bind(new TypeLiteral<Supplier<AccessControlRules>>() {})
+                            .toProvider(() -> new LocalFileAccessControlRulesProvider<>(configuration, AccessControlRules.class))


Can we inject this Supplier instead of specifying a Provider implementation ?

In this case we don't have to build the configuration here

...plugin-toolkit/src/main/java/io/trino/plugin/base/security/FileBasedAccessControlModule.java

Praveen2112 · 2022-10-24T14:32:44Z

...-toolkit/src/main/java/io/trino/plugin/base/security/FileBasedSystemAccessControlModule.java

+            try {
+                refreshPeriod = config.getRefreshPeriod();
+            }
+            catch (IllegalArgumentException e) {
+                throw invalidRefreshPeriodException(config, configFilePath);
+            }
+            if (refreshPeriod.toMillis() == 0) {
+                throw invalidRefreshPeriodException(config, configFilePath);
+            }


Can we move this validation part of the config like public Optional<@MinDuration("1ms") Duration>.

We can use Optional too. Maybe it could go as a preparatory commit. WDYT ?

refactored - actually it was dead code - refreshperiod validation are based on annotations and included in config class

Praveen2112 · 2022-10-24T14:34:51Z

lib/trino-plugin-toolkit/src/main/java/io/trino/plugin/base/security/RulesProvider.java

+    public RulesProvider(FileBasedAccessControlConfig config, Class<R> clazz)
+    {
+        this.clazz = requireNonNull(clazz);
+        this.jsonPointer = requireNonNull(config.getJsonPointer());


Do we need this jsonPointer for LocalFileBasedImpl since in the docs it has been restricted.

jsonPointer is only for rest based config now

cla-bot · 2022-11-02T11:53:05Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2022-11-03T12:50:00Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Praveen2112 · 2022-11-03T12:52:01Z

Can you please squash the commits.

cla-bot · 2022-11-03T13:57:44Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

arkadiuszbalcerek · 2022-11-03T14:04:45Z

@Praveen2112 please trigger the checks. Actually the code was refactored quite a lot so most of the comment shouldn't be relevant any more. Please review.

arkadiuszbalcerek · 2022-12-19T15:05:11Z

@Praveen2112 I applied the comments. Please review

Praveen2112 · 2022-12-20T10:51:19Z

lib/trino-plugin-toolkit/src/test/java/io/trino/plugin/base/util/TestingHttpServer.java

+                .initialize();
+
+        lifeCycleManager = injector.getInstance(LifeCycleManager.class);
+        baseUri = injector.getInstance(io.airlift.http.server.testing.TestingHttpServer.class).getBaseUrl();


Instead of getting instance of TestingHttpServer - can we fetch HttpServerInfo and get the Url based on it ? So we don't specify a class name with package.

Praveen2112 · 2022-12-20T10:53:29Z

...-toolkit/src/main/java/io/trino/plugin/base/security/FileBasedSystemAccessControlModule.java

+                            .setRequestTimeout(Duration.succinctDuration(10, TimeUnit.SECONDS))
+                            .setSelectorCount(1)
+                            .setMinThreads(1));
+            binder.bind(AccessControlRulesRestExtractor.class);


We need to specify the scope as Singleton

Praveen2112 · 2022-12-20T11:01:32Z

...-toolkit/src/main/java/io/trino/plugin/base/security/FileBasedSystemAccessControlModule.java

+            return () -> parseJson(readFile(configFile), config.getJsonPointer(), FileBasedSystemAccessControlRules.class);
+        }
+
+        private String readFile(File configFile)


JsonUtils has a method to read input from file - can we use that implementation

Praveen2112 · 2022-12-20T11:01:51Z

...-toolkit/src/main/java/io/trino/plugin/base/security/FileBasedSystemAccessControlModule.java

+        configBinder(binder).bindConfig(FileBasedAccessControlConfig.class);
+        install(conditionalModule(
+                FileBasedAccessControlConfig.class,
+                systemAccessControlConfig -> systemAccessControlConfig.isHttp(),


Can we use lambda here ?

Praveen2112 · 2022-12-20T11:02:31Z

...plugin-toolkit/src/main/java/io/trino/plugin/base/security/FileBasedAccessControlModule.java

    {
        configBinder(binder).bindConfig(FileBasedAccessControlConfig.class);
+        install(conditionalModule(
+                FileBasedAccessControlConfig.class,
+                accessControlConfig -> accessControlConfig.isHttp(),


We can use lambda here.

Praveen2112 · 2022-12-20T11:03:10Z

...plugin-toolkit/src/main/java/io/trino/plugin/base/security/FileBasedAccessControlConfig.java

+
+    public boolean isHttp()
+    {
+        if (configFile.startsWith("https://") || configFile.startsWith("http://")) {


can we something like this - return configFile.startsWith("https://") || configFile.startsWith("http://"))

Praveen2112 · 2022-12-20T11:04:00Z

...plugin-toolkit/src/main/java/io/trino/plugin/base/security/FileBasedAccessControlConfig.java

+    @AssertTrue(message = "Config file does not exist.")
+    public boolean isConfigFileValid()
+    {
+        if (Objects.nonNull(configFile) && !isHttp() && !new File(configFile).exists()) {


We don't have to add non-null check here - Can we move it to the end of class ?

hmm not sure if we don't need non-null check here. We have NotNull validation for configFile field. You shouldn't relay on order of validations, If I remove this non-null check we might (and will in this case) end up with NPE instead of NotNull validation failure

Custom validation happens after the getter/setter validation happens - so NotNull will be checked already. I think this non-null check would be redundant

Praveen2112 · 2022-12-20T11:04:46Z

...plugin-toolkit/src/main/java/io/trino/plugin/base/security/FileBasedAccessControlModule.java

+            return accessControlRulesProvider;
+        }
+
+        private String readFile(File configFile)


Praveen2112 · 2022-12-20T11:10:02Z

...plugin-toolkit/src/main/java/io/trino/plugin/base/security/FileBasedSystemAccessControl.java

            FileBasedAccessControlConfig fileBasedAccessControlConfig = injector.getInstance(FileBasedAccessControlConfig.class);
-            String configFileName = fileBasedAccessControlConfig.getConfigFile().getPath();
+            String configFile = fileBasedAccessControlConfig.getConfigFile();
+            Supplier<FileBasedSystemAccessControlRules> rulesProvider = injector.getInstance(Key.get(new TypeLiteral<Supplier<FileBasedSystemAccessControlRules>>() {}));


Can make it to be in-sync with FileBasedConnectorAccessControl implementation - Like we can we have a prep commit - which would introduce this a new FileBasedSystemAccessControlModule() which would inject a SystemAccessControl (wrapped with refresh option if required) and here we could configure the injector - to get an instance of the SystemAccessControl - this would make the design uniform and simple. WDYT ?

added prep commit with this refactoring before applying any new changes

arkadiuszbalcerek · 2022-12-21T06:53:28Z

Hi @Praveen2112 I applied the comments. please review

Praveen2112

Minor changes

Praveen2112 · 2022-12-21T10:07:08Z

...-toolkit/src/main/java/io/trino/plugin/base/security/FileBasedSystemAccessControlModule.java

+    }
+
+    @Inject
+    @Provides


@singleton annotation is missing.

Praveen2112 · 2022-12-21T10:08:44Z

core/trino-main/src/test/java/io/trino/security/TestFileBasedSystemAccessControl.java

@@ -15,6 +15,7 @@

 import com.google.common.collect.ImmutableMap;


Can we rename the commit message as Extract new module for FileBasedSystemAccessControl

Praveen2112 · 2022-12-21T10:09:07Z

core/trino-main/src/test/java/io/trino/security/TestFileBasedSystemAccessControl.java

@@ -819,23 +820,23 @@ public void testRefreshing()
    public void testAllowModeIsRequired()
    {
        assertThatThrownBy(() -> newAccessControlManager(createTestTransactionManager(), "catalog_allow_unset.json"))
-                .isInstanceOf(IllegalArgumentException.class)
-                .hasMessageStartingWith("Invalid JSON file");
+                .isInstanceOf(ProvisionException.class)


Do we need this change in this commit ?

Praveen2112 · 2022-12-21T10:12:57Z

...kit/src/test/java/io/trino/plugin/base/security/BaseFileBasedConnectorAccessControlTest.java

@@ -0,0 +1,714 @@
+/*


Try to keep the commit message less than 75 character length.

Praveen2112 · 2022-12-21T10:14:23Z

...gin-toolkit/src/main/java/io/trino/plugin/base/security/AccessControlRulesRestExtractor.java

+import static java.lang.String.format;
+import static java.util.Objects.requireNonNull;
+
+public class AccessControlRulesRestExtractor


nit : Can we rename it as RestBasedAccessControlRulesProvider

HttpBasedAccessControlRulesProvider? to stick to the convention and avoid rest?

Praveen2112 · 2022-12-21T10:14:45Z

...gin-toolkit/src/main/java/io/trino/plugin/base/security/AccessControlRulesRestExtractor.java

+    public <R> R extract(Class<R> clazz)
+    {
+        String body = getRawJsonString();
+        return parseJson(body, jsonPointer, clazz);


Can we inline body

Praveen2112 · 2022-12-21T10:19:50Z

...plugin-toolkit/src/main/java/io/trino/plugin/base/security/FileBasedAccessControlConfig.java

+    @AssertTrue(message = "Config file does not exist.")
+    public boolean isConfigFileValid()
+    {
+        if (Objects.nonNull(configFile) && !isHttp() && !new File(configFile).exists()) {


Custom validation happens after the getter/setter validation happens - so NotNull will be checked already. I think this non-null check would be redundant

Praveen2112 · 2022-12-21T10:20:33Z

...plugin-toolkit/src/main/java/io/trino/plugin/base/security/FileBasedAccessControlConfig.java


 public class FileBasedAccessControlConfig
 {
    public static final String SECURITY_CONFIG_FILE = "security.config-file";
    public static final String SECURITY_REFRESH_PERIOD = "security.refresh-period";
+    public static final String SECURITY_JSON_POINTER = "security.json-pointer";


Can we inline this string

Praveen2112 · 2022-12-21T10:23:00Z

...in-toolkit/src/test/java/io/trino/plugin/base/security/TestFileBasedAccessControlConfig.java

+                        .setConfigFile(securityConfigUrl)
+                        .setRefreshPeriod(Duration.valueOf("1ms"))
+                        .setJsonPointer("/data"));
+    }


test for non-existing file ?

it was already added in testValidationWithLocalFile

arkadiuszbalcerek · 2022-12-21T11:04:33Z

@Praveen2112 Regarding this one #14008 (comment) we need to change the test in this commit. After refactoring FileBasedSystemAccessControl they failed (different exception thrown)

arkadiuszbalcerek · 2022-12-21T12:08:40Z

@Praveen2112 comments applied

arkadiuszbalcerek · 2022-12-21T13:04:08Z

Hi @mosabua could you please have a look at docs change?

Praveen2112 · 2022-12-27T02:44:08Z

Merged !! Thanks for working on this

arkadiuszbalcerek · 2022-12-27T18:31:12Z

Thanks!!

github-actions bot added the docs label Sep 6, 2022

Praveen2112 reviewed Sep 8, 2022

View reviewed changes

github-actions bot added jdbc Relates to Trino JDBC driver release-notes tests:hive labels Sep 12, 2022

Praveen2112 reviewed Sep 12, 2022

View reviewed changes

arkadiuszbalcerek force-pushed the mck branch from 5f4f5b3 to b01fe55 Compare September 13, 2022 08:42

arkadiuszbalcerek force-pushed the mck branch from b01fe55 to 4920444 Compare September 13, 2022 11:01

arkadiuszbalcerek force-pushed the mck branch from 4920444 to ba82607 Compare September 13, 2022 11:22

martint removed the release-notes label Sep 21, 2022

Praveen2112 reviewed Oct 24, 2022

View reviewed changes

github-actions bot added the release-notes label Nov 2, 2022

arkadiuszbalcerek force-pushed the mck branch 3 times, most recently from 4f6ed63 to 4d522da Compare December 19, 2022 15:04

martint force-pushed the master branch from 40dbb4f to 0d73d10 Compare December 19, 2022 20:15

Praveen2112 reviewed Dec 20, 2022

View reviewed changes

arkadiuszbalcerek force-pushed the mck branch 2 times, most recently from 8df2a0f to 31c9159 Compare December 20, 2022 18:22

Praveen2112 approved these changes Dec 21, 2022

View reviewed changes

arkadiuszbalcerek force-pushed the mck branch from 31c9159 to 79be898 Compare December 21, 2022 12:07

arkadiuszbalcerek force-pushed the mck branch from 79be898 to 4d8dce0 Compare December 21, 2022 12:58

arkadiuszbalcerek force-pushed the mck branch from 4d8dce0 to e99cb89 Compare December 21, 2022 14:04

arkadiuszbalcerek added 3 commits December 23, 2022 08:53

Extract new module for FileBasedSystemAccessControl

185467f

Use assertFailsValidation in TestFileBasedAccessControlConfig

9278e58

Extract tests for Connector and System Access Control to base test

1558d1b

arkadiuszbalcerek force-pushed the mck branch from e99cb89 to eedbc7f Compare December 23, 2022 08:29

Allow fetching file based access control rules via http(s) url

05ce7ae

arkadiuszbalcerek force-pushed the mck branch from eedbc7f to 05ce7ae Compare December 23, 2022 11:36

Praveen2112 merged commit 4b7ae0a into trinodb:master Dec 27, 2022

github-actions bot added this to the 404 milestone Dec 27, 2022

colebow mentioned this pull request Dec 28, 2022

Add Trino 405 release notes #15139

Merged

guyco33 mentioned this pull request Jan 3, 2023

Query fails when masking function uses a column #15583

Closed

arekbalcerek deleted the mck branch January 4, 2024 22:32

arekbalcerek restored the mck branch January 4, 2024 22:32

		@@ -15,6 +15,7 @@

		import com.google.common.collect.ImmutableMap;

Allow fetching file based access provider rules via http(s) url #14008

Allow fetching file based access provider rules via http(s) url #14008

Conversation

arkadiuszbalcerek commented Sep 6, 2022 • edited Loading

Description

Related issues, pull requests, and links

Documentation

Release notes

cla-bot bot commented Sep 6, 2022

arkadiuszbalcerek commented Sep 6, 2022 • edited Loading

kokosing commented Sep 6, 2022

Praveen2112 commented Sep 6, 2022

cla-bot bot commented Sep 7, 2022

arkadiuszbalcerek commented Sep 7, 2022

Praveen2112 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cla-bot bot commented Sep 12, 2022

cla-bot bot commented Sep 12, 2022

cla-bot bot commented Sep 12, 2022

Praveen2112 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cla-bot bot commented Sep 13, 2022

cla-bot bot commented Sep 13, 2022

cla-bot bot commented Sep 13, 2022

AdrianSkierniewski commented Oct 24, 2022

Praveen2112 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Praveen2112 Oct 24, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cla-bot bot commented Nov 2, 2022

cla-bot bot commented Nov 3, 2022

Praveen2112 commented Nov 3, 2022

cla-bot bot commented Nov 3, 2022

arkadiuszbalcerek commented Nov 3, 2022

arkadiuszbalcerek commented Dec 19, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

arkadiuszbalcerek commented Sep 6, 2022 •

edited

Loading

arkadiuszbalcerek commented Sep 6, 2022 •

edited

Loading

Praveen2112 Oct 24, 2022 •

edited

Loading