Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style edits for OIDC warning #13830

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Style edits for OIDC warning #13830

merged 1 commit into from
Oct 17, 2022

Conversation

Jessie212
Copy link
Contributor

Description

Is this change a fix, improvement, new feature, refactoring, or other?

Improvement.

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Changes made to documentation.

How would you describe this change to a non-technical end user or system administrator?

Edit warning in OIDC section.

Related issues, pull requests, and links

Documentation

( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Aug 24, 2022
@Jessie212 Jessie212 requested a review from jhlodin August 24, 2022 15:43
jhlodin
jhlodin approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@jhlodin jhlodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % minor edits

docs/src/main/sphinx/security/oauth2.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/security/oauth2.rst Outdated Show resolved Hide resolved
@jhlodin
Copy link
Contributor

jhlodin commented Aug 24, 2022

Suggest renaming the commit and PR title to "Style edits for OIDC warning" or similar, just slightly more descriptive of why the change is being made.

@Jessie212 Jessie212 changed the title Edit OIDC warning Style edits for OIDC warning Aug 24, 2022
@github-actions github-actions bot added the docs label Aug 24, 2022
mosabua
mosabua approved these changes Sep 1, 2022
View reviewed changes
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks

@electrum electrum merged commit b95b894 into trinodb:master Oct 17, 2022
@Jessie212 Jessie212 deleted the jt/OIDC-warning branch October 17, 2022 18:43
@github-actions github-actions bot added this to the 401 milestone Oct 17, 2022
@colebow colebow mentioned this pull request Oct 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasz-walkiewicz lukasz-walkiewicz lukasz-walkiewicz approved these changes

@jhlodin jhlodin jhlodin approved these changes

@mosabua mosabua mosabua approved these changes

Assignees
No one assigned
Labels
cla-signed docs
Milestone
401
Development

Successfully merging this pull request may close these issues.
5 participants
@Jessie212 @jhlodin @mosabua @lukasz-walkiewicz @electrum