Clean up optimization docs & add syntactic join ordering section #13608
Conversation
colebow
force-pushed
the
colebow/optimization-docs
branch
3 times, most recently
from
e9f714f to
a909a81
Compare
colebow
force-pushed
the
colebow/optimization-docs
branch
from
a909a81 to
7b964ad
Compare
| If using ``AUTOMATIC`` and statistics are not available, or if for any other | ||
| reason a cost could not be computed, the ``ELIMINATE_CROSS_JOINS`` strategy is | ||
| used instead. | ||
| If you are using ``AUTOMATIC`` join enumeration and statistics are not |
There was a problem hiding this comment.
Does the properties reference docs for this property link to here ?
There was a problem hiding this comment.
looks like there is no link to this from properties-optimizer.rst .. we should add that
colebow
force-pushed
the
colebow/optimization-docs
branch
from
7b964ad to
50aff3c
Compare
colebow
force-pushed
the
colebow/optimization-docs
branch
4 times, most recently
from
aea1d2a to
077f498
Compare
colebow
force-pushed
the
colebow/optimization-docs
branch
from
077f498 to
cfa4a7e
Compare
| If using ``AUTOMATIC`` and statistics are not available, or if for any other | ||
| reason a cost could not be computed, the ``ELIMINATE_CROSS_JOINS`` strategy is | ||
| used instead. | ||
| If you are using ``AUTOMATIC`` join enumeration and statistics are not |
| If using ``AUTOMATIC`` and statistics are not available, or if for any other | ||
| reason a cost could not be computed, the ``ELIMINATE_CROSS_JOINS`` strategy is | ||
| used instead. | ||
| If you are using ``AUTOMATIC`` join enumeration and statistics are not |
There was a problem hiding this comment.
looks like there is no link to this from properties-optimizer.rst .. we should add that
| The join distribution type is automatically chosen when the join reordering | ||
| strategy is set to ``AUTOMATIC`` or when the join distribution type is set to | ||
| ``AUTOMATIC``. In both cases, it is possible to cap the maximum size of the | ||
| replicated table with the ``join-max-broadcast-table-size`` configuration |
There was a problem hiding this comment.
We should add this properties to properties-optimizer.rst .. even if just a small section with link to here
colebow
force-pushed
the
colebow/optimization-docs
branch
from
cfa4a7e to
a402307
Compare
I've added a line which suggests it. I think if a user isn't savvy enough to understand without an explicit example of that, we probably don't need them trying to go crazy with this. |
|
LGTM. @mosabua are there some changes here you want to be addressed or should I merge already? |
I'm personally leaving those to a different PR because I think addressing different files which link to here is outside the scope of this PR/change. |
|
Lets merge this. @colebow can follow up. |
Description
Improvements to optimization docs (formatting & grammar), then adding a new section on how to best optimize for syntactic join ordering.
Improvement
Docs
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: