Add Iceberg MinIO connector smoke test #11219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aczajkowski
force-pushed
the
acz/inceberg_minio_smoke_test
branch
from
3d78241 to
79f9290
Compare
losipiuk
reviewed
Mar 1, 2022
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/IcebergQueryRunner.java
Show resolved
Hide resolved
losipiuk
reviewed
Mar 1, 2022
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/IcebergQueryRunner.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Mar 1, 2022
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/SchemaInitializer.java
Show resolved
Hide resolved
losipiuk
reviewed
Mar 1, 2022
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/SchemaInitializer.java
Show resolved
Hide resolved
losipiuk
reviewed
Mar 1, 2022
...no-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergDynamicPartitionPruningTest.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Mar 1, 2022
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergMergeAppend.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Mar 1, 2022
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
findepi
approved these changes
Mar 1, 2022
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
.../trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergMinioConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
.../trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergMinioConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
.../trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergMinioConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
aczajkowski
force-pushed
the
acz/inceberg_minio_smoke_test
branch
from
79f9290 to
6c864a2
Compare
findepi
reviewed
Mar 1, 2022
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorSmokeTest.java
Show resolved
Hide resolved
findepi
reviewed
Mar 1, 2022
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
aczajkowski
force-pushed
the
acz/inceberg_minio_smoke_test
branch
from
6c864a2 to
56f1075
Compare
|
The diff provided by github (#11219 (comment)) is large: https://github.com/trinodb/trino/compare/6c864a2b89424c9e49144efc8d74e7b1027ec437..56f107589937f1e54e40a8bd824efac1bf89747f |
I was having a conflict. Rebase was required. |
findepi
approved these changes
Mar 1, 2022
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
.../trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergMinioConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
findepi
changed the title
aczajkowski
force-pushed
the
acz/inceberg_minio_smoke_test
branch
2 times, most recently
from
27aa80d to
95f1de0
Compare
aczajkowski
force-pushed
the
acz/inceberg_minio_smoke_test
branch
from
95f1de0 to
738cc1b
Compare
|
@findepi another conflicts. Rebased on master. |
aczajkowski
force-pushed
the
acz/inceberg_minio_smoke_test
branch
from
738cc1b to
b46e0d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce MinIO based data lake smoke tests for iceberg connector.
Redundant with: #10894 (2 first commits are shared)
We will merge eider Integration or Smoke test TBD.