Small code cleanup #10690
Merged
Small code cleanup #10690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no apparent advantage in calling `getIfPresent(key)` before calling `get(key)` on a loading cache.
ebyhr
approved these changes
Jan 19, 2022
hashhar
approved these changes
Jan 19, 2022
| @@ -494,10 +494,6 @@ private static PinotColumnHandle resolveAggregateExpressionWithAlias(PinotColumn | |||
|
|
|||
| private static <K, V> V getFromCache(LoadingCache<K, V> cache, K key) | |||
| { | |||
| V value = cache.getIfPresent(key); | |||
There was a problem hiding this comment.
IIRC there was some mention that getIfPresent is more contention safe than get? Or was it about computeIfAbsent?
I'll check and get back.
There was a problem hiding this comment.
However this doesn't seem to be in a hot path so shouldn't matter. Readability first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.