Follow the SQL standard in cast from double or real to varchar #10657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasiafi
force-pushed
the
295CastToVarcharApproxNumericFixFormat
branch
from
799ef4f to
0572fa4
Compare
kasiafi
force-pushed
the
295CastToVarcharApproxNumericFixFormat
branch
2 times, most recently
from
467e3cd to
323ee7c
Compare
kasiafi
force-pushed
the
295CastToVarcharApproxNumericFixFormat
branch
from
323ee7c to
9359d9c
Compare
findepi
approved these changes
Jan 20, 2022
| // String is all-ASCII, so String.length() here returns actual code points count | ||
| if (stringValue.length() <= x) { | ||
| return utf8Slice(stringValue); | ||
| } | ||
|
|
||
| throw new TrinoException(INVALID_CAST_ARGUMENT, format("Value %s cannot be represented as varchar(%s)", value, x)); | ||
| throw new TrinoException(INVALID_CAST_ARGUMENT, format("Value %s cannot be represented as varchar(%s)", stringValue, x)); |
There was a problem hiding this comment.
provide original value in the message, just in case we screw something up:
"Value %s (%s) ...", value, stringValue
There was a problem hiding this comment.
Applied to both double and real.
|
|
||
| // handle positive and negative 0 | ||
| if (value == 0e0) { | ||
| if (1e0 / value > 0) { |
There was a problem hiding this comment.
or, arguably more directly, Double.compare(0.0, value) == 0
the Double.compare sorts negative zero before positive zero
There was a problem hiding this comment.
I think it's clearer the way it is. Double.compare would require a comment.
kasiafi
force-pushed
the
295CastToVarcharApproxNumericFixFormat
branch
from
9359d9c to
7bb9d8f
Compare
kasiafi
force-pushed
the
295CastToVarcharApproxNumericFixFormat
branch
from
7bb9d8f to
ce125d0
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #552