Allow MockConnector to support table and schema properties #10618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kokosing
force-pushed
the
origin/master/297_mock_props
branch
from
0d0222f to
62cf13b
Compare
Praveen2112
reviewed
Jan 20, 2022
core/trino-main/src/test/java/io/trino/connector/MockConnector.java
Outdated
Show resolved
Hide resolved
kokosing
force-pushed
the
origin/master/297_mock_props
branch
from
62cf13b to
33df6f5
Compare
|
@gaurav8297 @Praveen2112 AC, PTAL |
Praveen2112
approved these changes
Jan 20, 2022
Procedures do not configure access control in MockConnector, so system access control should be used.
kokosing
force-pushed
the
origin/master/297_mock_props
branch
from
33df6f5 to
4453e36
Compare
kokosing
force-pushed
the
origin/master/297_mock_props
branch
from
4453e36 to
25bead9
Compare
linzebing
pushed a commit
to linzebing/trino
that referenced
this pull request
Jan 26, 2022
…0618) * Do not provide access control for procedures in MockConnector Procedures do not configure access control in MockConnector, so system access control should be used. * Allow MockConnector to support table and schema properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow MockConnector to support table and schema properties