Make scheduled stages order deterministic #10605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @martint |
|
This is based on |
sopel39
force-pushed
the
ks/deterministic_stages
branch
4 times, most recently
from
14506b3 to
9939117
Compare
losipiuk
reviewed
Jan 14, 2022
core/trino-main/src/main/java/io/trino/execution/scheduler/policy/PhasedExecutionSchedule.java
Show resolved
Hide resolved
losipiuk
reviewed
Jan 14, 2022
core/trino-main/src/main/java/io/trino/execution/scheduler/policy/PhasedExecutionSchedule.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Jan 14, 2022
core/trino-main/src/main/java/io/trino/execution/scheduler/policy/PhasedExecutionSchedule.java
Show resolved
Hide resolved
losipiuk
approved these changes
Jan 14, 2022
sopel39
force-pushed
the
ks/deterministic_stages
branch
from
9939117 to
6bd2370
Compare
The scheduler is single threaded per query so the actual order stages are processed in the scheduler can affect short queries on fast connectors.
sopel39
force-pushed
the
ks/deterministic_stages
branch
from
6bd2370 to
ca365e0
Compare
This was referenced Jan 17, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scheduler is single threaded per query so the actual order stages
are processed in the scheduler can affect short queries on fast connectors.