Remove shared mutable state for extra options handling in PTL #10603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Environment and extenders are singletons, so they should be immutable. Instead of passing the options in separate `setExtraOptions` call, pass them to `extendEnvironment`.
findepi
force-pushed
the
findepi/remove-shared-mutable-state-for-extra-options-handling-in-ptl-31845d
branch
from
6838e29 to
7afbc99
Compare
hashhar
approved these changes
Jan 18, 2022
findepi
deleted the
findepi/remove-shared-mutable-state-for-extra-options-handling-in-ptl-31845d
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment and extenders are singletons, so they should be immutable.
Instead of passing the options in separate
setExtraOptionscall, passthem to
extendEnvironment.