Document table statistics property for Hive connector #10525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
requested changes
Jan 10, 2022
rosewms
force-pushed
the
rw-hive-stats
branch
from
d203788 to
99b444a
Compare
mosabua
approved these changes
Jan 12, 2022
rosewms
changed the title
m57lyra
reviewed
Jan 13, 2022
| @@ -388,6 +388,11 @@ Property Name Description | |||
| ``hive.query-partition-filter-required`` Set to ``true`` to force a query to use a partition filter. ``false`` | |||
| You can use the ``query_partition_filter_required`` catalog | |||
| session property for temporary, catalog specific use. | |||
|
|
|||
| ``hive.statistics_enabled`` Disable :doc:`/optimizer/statistics`, and therefore ``true`` | |||
There was a problem hiding this comment.
it is confusing that the name of this is *enabled, but the description starts out with "Disable..." but the default is true.
hashhar
reviewed
Jan 13, 2022
rosewms
force-pushed
the
rw-hive-stats
branch
from
99b444a to
788633b
Compare
hashhar
approved these changes
Jan 13, 2022
Comment on lines
395
to
396
| Set to ``false`` to disable statistics, this also disables | ||
| :doc:`/optimizer/cost-based-optimizations`. |
There was a problem hiding this comment.
nitpicking - this is technically true but a side effect of the fact that stats become missing. i.e. there might be future cost-based optimisations which might not be dependent on stats (or we could generate some rough stats during runtime) and then this statement would be false.
There was a problem hiding this comment.
I could do a minor edit to say this or something similar:
Set to
falseto disable statistics. Disabling statistics
means that :doc:/optimizer/cost-based-optimizationscan
not make smart decisions about the query plan.
rosewms
force-pushed
the
rw-hive-stats
branch
from
788633b to
0e89a54
Compare
electrum
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.