Use append instead of fastAppend for Iceberg writes #10105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
reviewed
Nov 29, 2021
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergMergeAppend.java
Show resolved
Hide resolved
findepi
reviewed
Nov 30, 2021
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
Show resolved
Hide resolved
address comments
liqinrae
force-pushed
the
fastappend_fix
branch
from
189f147 to
513d36f
Compare
|
Merged as 0870114, thanks! had to update commit message. |
This was referenced Jan 14, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in issue #9340, although
fastApppendis faster when appending files to tables, it does not merge manifests during commits and results in slower scan planning over time.appendis a more adaptive method since it can be configured to merge manifests by setting the value ofcommit.manifest.min-count-to-mergeand only merge manifests when the size of the manifests is greater than the configured value.