Test concurrent metadata access

E.g. `SHOW TABLES` must not fail when tables, views or materialized views are concurrently created or dropped.
trinodb · Mar 4, 2022 · f712fe7 · f712fe7
1 parent e12a9b1
commit f712fe7
Show file tree

Hide file tree

Showing 9 changed files with 303 additions and 0 deletions.
diff --git a/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java b/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
@@ -302,6 +302,14 @@ protected void checkInformationSchemaViewsForMaterializedView(String schemaName,
                 .hasMessageFindingMatch("(?s)Expecting.*to contain:.*\\Q[(" + viewName + ")]");
     }
 
+    @Test(enabled = false) // TODO fails
+    @Override
+    public void testReadMetadataWithRelationsConcurrentModifications()
+            throws Exception
+    {
+        super.testReadMetadataWithRelationsConcurrentModifications();
+    }
+
     @Test
     public void testDecimal()
     {

diff --git a/plugin/trino-kudu/src/test/java/io/trino/plugin/kudu/AbstractKuduConnectorTest.java b/plugin/trino-kudu/src/test/java/io/trino/plugin/kudu/AbstractKuduConnectorTest.java
@@ -358,6 +358,13 @@ public void testWrittenStats()
         throw new SkipException("TODO");
     }
 
+    @Override
+    public void testReadMetadataWithRelationsConcurrentModifications()
+    {
+        // TODO Support these test once kudu connector can create tables with default partitions
+        throw new SkipException("TODO");
+    }
+
     @Test
     @Override
     public void testCreateTableAsSelectNegativeDate()

diff --git a/plugin/trino-phoenix/pom.xml b/plugin/trino-phoenix/pom.xml
@@ -190,6 +190,12 @@
             </exclusions>
         </dependency>
 
+        <dependency>
+            <groupId>io.trino</groupId>
+            <artifactId>trino-testing-services</artifactId>
+            <scope>test</scope>
+        </dependency>
+
         <dependency>
             <groupId>io.trino</groupId>
             <artifactId>trino-tpch</artifactId>

diff --git a/plugin/trino-phoenix/src/test/java/io/trino/plugin/phoenix/TestPhoenixConnectorTest.java b/plugin/trino-phoenix/src/test/java/io/trino/plugin/phoenix/TestPhoenixConnectorTest.java
@@ -22,6 +22,7 @@
 import io.trino.testing.TestingConnectorBehavior;
 import io.trino.testing.sql.SqlExecutor;
 import io.trino.testing.sql.TestTable;
+import io.trino.testng.services.Flaky;
 import org.testng.SkipException;
 import org.testng.annotations.AfterClass;
 import org.testng.annotations.Test;
@@ -220,6 +221,30 @@ public void testShowCreateTable()
                         ")");
     }
 
+    // TODO (https://github.com/trinodb/trino/issues/10904): Test is flaky because tests execute in parallel
+    @Flaky(issue = "https://github.com/trinodb/trino/issues/10904", match = "\\QERROR 1012 (42M03): Table undefined. tableName=")
+    @Test
+    @Override
+    public void testSelectInformationSchemaColumns()
+    {
+        super.testSelectInformationSchemaColumns();
+    }
+
+    @Override
+    public void testReadMetadataWithRelationsConcurrentModifications()
+    {
+        try {
+            super.testReadMetadataWithRelationsConcurrentModifications();
+        }
+        catch (Exception expected) {
+            // The test failure is not guaranteed
+            // TODO (https://github.com/trinodb/trino/issues/10904): shouldn't fail
+            assertThat(expected)
+                    .hasMessageContaining("ERROR 1012 (42M03): Table undefined. tableName=");
+            throw new SkipException("to be fixed");
+        }
+    }
+
     @Override
     public void testCharVarcharComparison()
     {

diff --git a/plugin/trino-phoenix5/pom.xml b/plugin/trino-phoenix5/pom.xml
@@ -195,6 +195,12 @@
             </exclusions>
         </dependency>
 
+        <dependency>
+            <groupId>io.trino</groupId>
+            <artifactId>trino-testing-services</artifactId>
+            <scope>test</scope>
+        </dependency>
+
         <dependency>
             <groupId>io.trino</groupId>
             <artifactId>trino-tpch</artifactId>

diff --git a/plugin/trino-phoenix5/src/test/java/io/trino/plugin/phoenix5/TestPhoenixConnectorTest.java b/plugin/trino-phoenix5/src/test/java/io/trino/plugin/phoenix5/TestPhoenixConnectorTest.java
@@ -24,6 +24,7 @@
 import io.trino.testing.TestingConnectorBehavior;
 import io.trino.testing.sql.SqlExecutor;
 import io.trino.testing.sql.TestTable;
+import io.trino.testng.services.Flaky;
 import org.testng.SkipException;
 import org.testng.annotations.AfterClass;
 import org.testng.annotations.Test;
@@ -238,6 +239,30 @@ public void testShowCreateTable()
                         ")");
     }
 
+    // TODO (https://github.com/trinodb/trino/issues/10904): Test is flaky because tests execute in parallel
+    @Flaky(issue = "https://github.com/trinodb/trino/issues/10904", match = "\\QERROR 1012 (42M03): Table undefined. tableName=")
+    @Test
+    @Override
+    public void testSelectInformationSchemaColumns()
+    {
+        super.testSelectInformationSchemaColumns();
+    }
+
+    @Override
+    public void testReadMetadataWithRelationsConcurrentModifications()
+    {
+        try {
+            super.testReadMetadataWithRelationsConcurrentModifications();
+        }
+        catch (Exception expected) {
+            // The test failure is not guaranteed
+            // TODO (https://github.com/trinodb/trino/issues/10904): shouldn't fail
+            assertThat(expected)
+                    .hasMessageContaining("ERROR 1012 (42M03): Table undefined. tableName=");
+            throw new SkipException("to be fixed");
+        }
+    }
+
     @Override
     public void testCharVarcharComparison()
     {

diff --git a/plugin/trino-sqlserver/pom.xml b/plugin/trino-sqlserver/pom.xml
@@ -140,6 +140,12 @@
             <scope>test</scope>
         </dependency>
 
+        <dependency>
+            <groupId>io.trino</groupId>
+            <artifactId>trino-testing-services</artifactId>
+            <scope>test</scope>
+        </dependency>
+
         <dependency>
             <groupId>io.trino</groupId>
             <artifactId>trino-tpch</artifactId>

diff --git a/...n/trino-sqlserver/src/test/java/io/trino/plugin/sqlserver/BaseSqlServerConnectorTest.java b/...n/trino-sqlserver/src/test/java/io/trino/plugin/sqlserver/BaseSqlServerConnectorTest.java
@@ -25,6 +25,8 @@
 import io.trino.sql.planner.plan.FilterNode;
 import io.trino.testing.TestingConnectorBehavior;
 import io.trino.testing.sql.TestTable;
+import io.trino.testng.services.Flaky;
+import org.testng.SkipException;
 import org.testng.annotations.DataProvider;
 import org.testng.annotations.Test;
 
@@ -135,6 +137,35 @@ public void testReadFromView()
         onRemoteDatabase().execute("DROP VIEW IF EXISTS test_view");
     }
 
+    // TODO (https://github.com/trinodb/trino/issues/10846): Test is expected to be flaky because tests execute in parallel
+    @Flaky(issue = "https://github.com/trinodb/trino/issues/10846", match = "was deadlocked on lock resources with another process and has been chosen as the deadlock victim")
+    @Test
+    @Override
+    public void testSelectInformationSchemaColumns()
+    {
+        super.testSelectInformationSchemaColumns();
+    }
+
+    @Test
+    @Override
+    public void testReadMetadataWithRelationsConcurrentModifications()
+    {
+        try {
+            super.testReadMetadataWithRelationsConcurrentModifications();
+        }
+        catch (Exception expected) {
+            // The test failure is not guaranteed
+            // TODO (https://github.com/trinodb/trino/issues/10846): shouldn't fail
+            assertThat(expected)
+                    .hasMessageMatching("(?s).*(" +
+                            "No task completed before timeout|" +
+                            "was deadlocked on lock resources with another process and has been chosen as the deadlock victim|" +
+                            // E.g. system.metadata.table_comments can return empty results, when underlying metadata list tables call fails
+                            "Expecting actual not to be empty).*");
+            throw new SkipException("to be fixed");
+        }
+    }
+
     @Test
     public void testColumnComment()
     {