Skip to content

Commit

Permalink
Use TimeStat addNanos where applicable
Browse files Browse the repository at this point in the history
  • Loading branch information
pettyjamesm authored and findepi committed Oct 26, 2022
1 parent bc38622 commit e2c1abd
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,9 @@ public CounterStat getTotalFailures()
return totalFailures;
}

public void recordCall(long executionTimeInMillis, boolean failure)
public void recordCall(long executionTimeNanos, boolean failure)
{
time.add(executionTimeInMillis, MILLISECONDS);
time.addNanos(executionTimeNanos);
if (failure) {
totalFailures.update(1);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -173,9 +173,9 @@ private static void recordSubTimingDurations(TimingInfo timingInfo, AWSRequestMe
List<TimingInfo> subTimings = timingInfo.getAllSubMeasurements(field.name());
if (subTimings != null) {
for (TimingInfo subTiming : subTimings) {
Double millis = subTiming.getTimeTakenMillisIfKnown();
if (millis != null) {
timeStat.add(millis, MILLISECONDS);
Long endTimeNanos = subTiming.getEndTimeNanoIfKnown();
if (endTimeNanos != null) {
timeStat.addNanos(endTimeNanos - subTiming.getStartTimeNano());
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@
import static io.trino.spi.StandardErrorCode.NOT_SUPPORTED;
import static io.trino.spi.security.PrincipalType.USER;
import static java.util.Objects.requireNonNull;
import static java.util.concurrent.TimeUnit.MILLISECONDS;
import static java.util.concurrent.TimeUnit.NANOSECONDS;
import static java.util.function.Predicate.not;
import static java.util.function.UnaryOperator.identity;
import static java.util.stream.Collectors.toCollection;
Expand Down Expand Up @@ -1141,13 +1141,13 @@ public StatsRecordingAsyncHandler(AwsApiCallStats stats)
@Override
public void onError(Exception e)
{
stats.recordCall(stopwatch.elapsed(MILLISECONDS), true);
stats.recordCall(stopwatch.elapsed(NANOSECONDS), true);
}

@Override
public void onSuccess(AmazonWebServiceRequest request, Object o)
{
stats.recordCall(stopwatch.elapsed(MILLISECONDS), false);
stats.recordCall(stopwatch.elapsed(NANOSECONDS), false);
}
}
}

0 comments on commit e2c1abd

Please sign in to comment.