Document safe & unsafe Cache invalidations

core/trino-main/src/main/java/io/trino/server/security/oauth2/OAuth2TokenExchange.java

@@ -91,6 +91,8 @@ public ListenableFuture<TokenPoll> getTokenPoll(UUID authId)
 
     public void dropToken(UUID authId)
     {
+        // TODO this may not invalidate ongoing loads (https://github.com/trinodb/trino/issues/10512, https://github.com/google/guava/issues/1881).
+        //   Determine whether this is OK here.
         cache.invalidate(hashAuthId(authId));
     }
 

core/trino-main/src/main/java/io/trino/type/BlockTypeOperators.java

@@ -284,6 +284,8 @@ public long getCacheRequestCount()
     @Managed
     public void cacheReset()
     {
+        // Note: this may not invalidate ongoing loads (https://github.com/trinodb/trino/issues/10512, https://github.com/google/guava/issues/1881)
+        // This is acceptable, since this operation is invoked manually, and not relied upon for correctness.
         generatedBlockOperatorCache.invalidateAll();
     }
 }

core/trino-main/src/main/java/io/trino/type/TypeOperatorsCache.java

@@ -71,6 +71,8 @@ public long getCacheRequestCount()
     @Managed
     public void cacheReset()
     {
+        // Note: this may not invalidate ongoing loads (https://github.com/trinodb/trino/issues/10512, https://github.com/google/guava/issues/1881)
+        // This is acceptable, since this operation is invoked manually, and not relied upon for correctness.
         cache.invalidateAll();
     }
 }

plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/mapping/CachingIdentifierMapping.java

@@ -73,6 +73,8 @@ public CachingIdentifierMapping(
 
     public void flushCache()
     {
+        // Note: this may not invalidate ongoing loads (https://github.com/trinodb/trino/issues/10512, https://github.com/google/guava/issues/1881)
+        // This is acceptable, since this operation is invoked manually, and not relied upon for correctness.
         remoteSchemaNames.invalidateAll();
         remoteTableNames.invalidateAll();
     }

plugin/trino-hive/src/main/java/io/trino/plugin/hive/CachingDirectoryLister.java

@@ -144,6 +144,8 @@ public LocatedFileStatus next()
     @Managed
     public void flushCache()
     {
+        // Note: this may not invalidate ongoing loads (https://github.com/trinodb/trino/issues/10512, https://github.com/google/guava/issues/1881)
+        // This is acceptable, since this operation is invoked manually, and not relied upon for correctness.
         cache.invalidateAll();
     }
 

plugin/trino-password-authenticators/src/main/java/io/trino/plugin/password/ldap/LdapAuthenticator.java

@@ -92,6 +92,8 @@ public LdapAuthenticator(LdapAuthenticatorClient client, LdapConfig ldapConfig)
     @VisibleForTesting
     void invalidateCache()
     {
+        // Note: this may not invalidate ongoing loads (https://github.com/trinodb/trino/issues/10512, https://github.com/google/guava/issues/1881)
+        // This is acceptable, since this operation is invoked in tests only, and not relied upon for correctness.
         authenticationCache.invalidateAll();
     }
 

plugin/trino-raptor-legacy/src/main/java/io/trino/plugin/raptor/legacy/storage/ShardRecoveryManager.java

@@ -427,6 +427,8 @@ public ListenableFuture<Void> load(MissingShard missingShard)
                             missingShard.getShardXxhash64(),
                             missingShard.isActive());
                     ListenableFuture<Void> future = shardRecoveryExecutor.submit(task);
+                    // TODO this may not invalidate ongoing loads (https://github.com/trinodb/trino/issues/10512, https://github.com/google/guava/issues/1881).
+                    //   Determine whether this is OK here.
                     future.addListener(() -> queuedMissingShards.invalidate(missingShard), directExecutor());
                     return future;
                 }