Abstain from overriding @BeforeClass init method

There is no need for that, and thus it should be avoided, as it introduces unnecessary flow dependencies, or ordering of events. Regular `@BeforeClass` should be used instead.
trinodb · Jan 18, 2022 · 2874b92 · 2874b92
1 parent afebf3f
commit 2874b92
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/testing/trino-testing/src/main/java/io/trino/testing/AbstractTestFailureRecovery.java b/testing/trino-testing/src/main/java/io/trino/testing/AbstractTestFailureRecovery.java
@@ -107,11 +107,9 @@ protected abstract QueryRunner createQueryRunner(List<TpchTable<?>> requiredTpch
             throws Exception;
 
     @BeforeClass
-    @Override
-    public void init()
+    public void initTables()
             throws Exception
     {
-        super.init();
         // setup partitioned fact table for dynamic partition pruning
         createPartitionedLineitemTable(PARTITIONED_LINEITEM, ImmutableList.of("orderkey", "partkey", "suppkey"), "suppkey");
     }

diff --git a/testing/trino-testing/src/main/java/io/trino/testing/BaseDynamicPartitionPruningTest.java b/testing/trino-testing/src/main/java/io/trino/testing/BaseDynamicPartitionPruningTest.java
@@ -64,11 +64,9 @@ public abstract class BaseDynamicPartitionPruningTest
             "optimizer.rewrite-filtering-semi-join-to-inner-join", "false");
 
     @BeforeClass
-    @Override
-    public void init()
+    public void initTables()
             throws Exception
     {
-        super.init();
         // setup partitioned fact table for dynamic partition pruning
         createLineitemTable(PARTITIONED_LINEITEM, ImmutableList.of("orderkey", "partkey", "suppkey"), ImmutableList.of("suppkey"));
     }