Android fixes: support uglify and markMode #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/pager.android.ts
triniwiz
reviewed
Mar 28, 2019
| @@ -401,279 +380,290 @@ export class PagerFragment extends android.support.v4.app.Fragment { | |||
| } | |||
| } | |||
|
|
|||
| export class PagerStateAdapter extends android.support.v4.view.PagerAdapter { | |||
| let PagerStateAdapter: PagerStateAdapter; | |||
| interface PagerStateAdapter extends com.lambergar.verticalviewpager.PagerAdapter { | |||
There was a problem hiding this comment.
com.lambergar.verticalviewpager has not been added to this pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
warning though this PR is not yet compatible with my other one. i advise to merge this one first and i ll update the other one