Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual page change is not animated in ios #50

Closed
kwidzinskidawid opened this issue Mar 13, 2018 · 5 comments
Closed

Manual page change is not animated in ios #50

kwidzinskidawid opened this issue Mar 13, 2018 · 5 comments

Comments

@kwidzinskidawid
Copy link

Which platform(s) does your issue occur on?

  • iOS
  • emulator and device

Please, provide the following version numbers that your issue occurs with:

  • CLI: 3.4.1
  • Cross-platform modules: 3.4.0
  • Runtime(s): 3.4.0
  • Plugin(s): 7.1.3

Please, tell us how to recreate the issue in as much detail as possible.

When manually (programmatically) setting current pager index, pager instantly changes page to new index, without transition.
On android page change is smoothly animated.

Example gif in readme here suggests that switching pages should be animated (clicking previous and next page). I tried downloading demo but its the same thing. Pages are instantly changed without transition.

@triniwiz
Copy link
Owner

Yeah i disabled it -> here at the time of debuging a crash that seemed to becausing problems i can look at it again or if you want to test it change it to true LMK how it works 😄

@kwidzinskidawid
Copy link
Author

Thanks for a quick response. Yes, changing that third parameter to true fixes it. I tested it on an emulator and on a device and everything seems fine. Do you think you could look at it again to see if it really causes any trouble? Or if its too much trouble, maybe make that boolean variable as a pager attribute that defaults to false so i can turn those animations at my own responsibility 😄

@triniwiz
Copy link
Owner

so now it's enabled by default use disableAnimation="true" if you don't need it

@kwidzinskidawid
Copy link
Author

kwidzinskidawid commented Mar 15, 2018

Thanks for a quick change, everything looks great except animations are working when disabledAnimation is set to true.
I guess here has to be !this.disableAnimation, since the argument says if the animations are enabled

@triniwiz
Copy link
Owner

lol my bad (rushing to get it complete) 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants