Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

Drawer: Rename temporary drawer #534

Closed
9 of 10 tasks
trimox opened this issue Jan 12, 2018 · 0 comments
Closed
9 of 10 tasks

Drawer: Rename temporary drawer #534

trimox opened this issue Jan 12, 2018 · 0 comments
Assignees
Labels
enhancement new-mdc-feature Feature incorporated from material-components-web

Comments

@trimox
Copy link
Owner

trimox commented Jan 12, 2018

Change as per material-components-web v0.28.0
reference: material-components/material-components-web#1730

  • Rename mdc-temporary-drawer to mdc-drawer-temporary
  • Rename MdcDrawerTemporary class to MdcDrawerTemporary
  • Rename mdc-temporary-drawer-header to mdc-drawer-header
  • Rename mdc-temporary-drawer-header-content to mdc-drawer-header-content
  • Rename mdc-temporary-drawer-spacer to mdc-drawer-spacer
  • Rename mdc-temporary-drawer-content to mdc-drawer-content
  • Rename mdc-temporary-drawer--absolute' css class to ng-mdc-drawer--absolute`. Avoids confusion with mdc naming.
  • Update unit tests
  • Update documentation
  • Include breaking change note
@trimox trimox added enhancement new-mdc-feature Feature incorporated from material-components-web labels Jan 12, 2018
@trimox trimox added this to the Milestone v0.6.7 milestone Jan 12, 2018
@trimox trimox self-assigned this Jan 12, 2018
trimox added a commit that referenced this issue Jan 12, 2018
Change as per `material-components-web` v0.28.0
reference: material-components/material-components-web#1730

- Rename `mdc-temporary-drawer` to `mdc-drawer-temporary`
- Rename `MdcDrawerTemporary` class to `MdcDrawerTemporary`
- Rename `mdc-temporary-drawer-header` to `mdc-drawer-header`
- Rename `mdc-temporary-drawer-header-content` to `mdc-drawer-header-content`
- Rename `mdc-temporary-drawer-spacer` to `mdc-drawer-spacer`
- Rename `mdc-temporary-drawer-content` to `mdc-drawer-content`
- Rename `mdc-temporary-drawer--absolute' css class to `ng-mdc-drawer--absolute`. Avoids confusion with mdc naming.
- Update unit tests
- Update documentation

* Renamed selector `mdc-temporary-drawer` to `mdc-drawer-temporary`.
* Renamed class `MdcDrawerTemporary` to `MdcDrawerTemporary`.
* Renamed selector `mdc-temporary-drawer-spacer` to `mdc-drawer-spacer`.
* Renamed selector `mdc-temporary-drawer-content` to `mdc-drawer-content`.
* Renamed `mdc-temporary-drawer-header` to `mdc-drawer-header`
* Renamed `mdc-temporary-drawer-header-content` to `mdc-drawer-header-content`

Closes #534
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement new-mdc-feature Feature incorporated from material-components-web
Projects
None yet
Development

No branches or pull requests

1 participant