Dropping support for Makefile.export.* files and update find_package(Trilinos) doc some (trilinos/Trilinos#8498) #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modern CMake does not well support the generation of Makefile fragment files for usage by Makefile build systems so we must remove this. See trilinos/Trilinos#8498 and TriBITSPub/TriBITS#299.
Here I mostly just did: * Updated link to demos/simpleBuildAgainstTrilinos * Lower-case CMake commands * Put '()' after CMake command names * Remove the untested example CMakeLists.txt file and instead point to the (somewhat) tested demos/simpleBuildAgainstTrilinos/CMakeLists.txt file This really should be formatted as a Markdown file and update the suggestions on how to use this but these are the miniumum changes for trilinos/Trilinos#8498.
8 tasks
|
Okay, I will go ahead and merge based on trilinos/Trilinos#8498 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the documentation on trilinos.github.io related to trilinos/Trilinos#8498 (see commits for more detail).