Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tempus: Split StepperFactory.hpp. #7940

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

ccober6
Copy link
Contributor

@ccober6 ccober6 commented Aug 31, 2020

Split StepperFactory.hpp into StepperFactory_decl.hpp and
StepperFactory_impl.hpp for ETI.

  • Made createMultiSteppers() name uniform with, e.g.,
    changed to createStepper().

@trilinos/tempus

Motivation

Make StepperFactory ready for ETI.

Testing

All tests are passing.

Split StepperFactory.hpp into StepperFactory_decl.hpp and
StepperFactory_impl.hpp fro ETI.

 * Made createMultiSteppers() name uniform with, e.g.,
   changed to createStepper().
@ccober6 ccober6 requested a review from asteyer August 31, 2020 13:21
@ccober6 ccober6 self-assigned this Aug 31, 2020
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 7710
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PR_LABELS pkg: Tempus
PULLREQUESTNUM 7940
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7939-Tempus-Split-StepperFactory_hpp
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA db46540
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 6761d1a

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 7520
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Tempus
PULLREQUESTNUM 7940
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7939-Tempus-Split-StepperFactory_hpp
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA db46540
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 6761d1a

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 5945
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Tempus
PULLREQUESTNUM 7940
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7939-Tempus-Split-StepperFactory_hpp
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA db46540
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 6761d1a

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_debug

  • Build Num: 165
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Tempus
PULLREQUESTNUM 7940
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7939-Tempus-Split-StepperFactory_hpp
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA db46540
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 6761d1a

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 1981
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Tempus
PULLREQUESTNUM 7940
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7939-Tempus-Split-StepperFactory_hpp
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA db46540
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 6761d1a

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 5277
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Tempus
PULLREQUESTNUM 7940
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7939-Tempus-Split-StepperFactory_hpp
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA db46540
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 6761d1a

Build Information

Test Name: Trilinos_pullrequest_clang_10.0.0

  • Build Num: 426
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Tempus
PULLREQUESTNUM 7940
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7939-Tempus-Split-StepperFactory_hpp
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA db46540
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 6761d1a

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 3274
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Tempus
PULLREQUESTNUM 7940
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7939-Tempus-Split-StepperFactory_hpp
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA db46540
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 6761d1a

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 3295
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Tempus
PULLREQUESTNUM 7940
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7939-Tempus-Split-StepperFactory_hpp
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA db46540
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 6761d1a

Using Repos:

Repo: TRILINOS (trilinos/Trilinos)
  • Branch: 7939-Tempus-Split-StepperFactory_hpp
  • SHA: db46540
  • Mode: TEST_REPO

Pull Request Author: ccober6

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 7710
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PR_LABELS pkg: Tempus
PULLREQUESTNUM 7940
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7939-Tempus-Split-StepperFactory_hpp
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA db46540
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 6761d1a

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 7520
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Tempus
PULLREQUESTNUM 7940
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7939-Tempus-Split-StepperFactory_hpp
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA db46540
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 6761d1a

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 5945
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Tempus
PULLREQUESTNUM 7940
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7939-Tempus-Split-StepperFactory_hpp
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA db46540
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 6761d1a

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_debug

  • Build Num: 165
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Tempus
PULLREQUESTNUM 7940
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7939-Tempus-Split-StepperFactory_hpp
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA db46540
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 6761d1a

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 1981
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Tempus
PULLREQUESTNUM 7940
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7939-Tempus-Split-StepperFactory_hpp
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA db46540
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 6761d1a

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 5277
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Tempus
PULLREQUESTNUM 7940
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7939-Tempus-Split-StepperFactory_hpp
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA db46540
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 6761d1a

Build Information

Test Name: Trilinos_pullrequest_clang_10.0.0

  • Build Num: 426
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Tempus
PULLREQUESTNUM 7940
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7939-Tempus-Split-StepperFactory_hpp
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA db46540
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 6761d1a

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 3274
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Tempus
PULLREQUESTNUM 7940
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7939-Tempus-Split-StepperFactory_hpp
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA db46540
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 6761d1a

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 3295
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Tempus
PULLREQUESTNUM 7940
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7939-Tempus-Split-StepperFactory_hpp
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA db46540
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 6761d1a


CDash Test Results for PR# 7940.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@ccober6 ccober6 requested a review from sconde August 31, 2020 19:52
Copy link
Contributor

@sconde sconde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ sconde ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR...

@ccober6 ccober6 merged commit b16d77b into develop Aug 31, 2020
@ccober6 ccober6 deleted the 7939-Tempus-Split-StepperFactory_hpp branch October 6, 2020 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants