Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ATDM/apps: Turn fPIC on by default for EMPIRE builds of Trilinos #7904

Merged
merged 1 commit into from
Aug 25, 2020
Merged

ATDM/apps: Turn fPIC on by default for EMPIRE builds of Trilinos #7904

merged 1 commit into from
Aug 25, 2020

Conversation

e10harvey
Copy link
Contributor

How was this tested?

Minimally by configuring Trilinos and looking at the generated makefiles:

cmake -D Trilinos_CONFIGURE_OPTIONS_FILE:STRING=cmake/std/atdm/ATDMDevEnv.cmake,cmake/std/atdm/apps/empire/EMPIRETrilinosEnables.cmake ../
<snip>
grep -i fpic CMakeCache.txt 
CMAKE_CXX_FLAGS:STRING=  -fPIC

@e10harvey e10harvey requested a review from jmgate August 25, 2020 18:11
@e10harvey e10harvey self-assigned this Aug 25, 2020
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 7665
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PR_LABELS
PULLREQUESTNUM 7904
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH topic/default_to_fpic
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA e31132f
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 05558e9

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 7475
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS
PULLREQUESTNUM 7904
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH topic/default_to_fpic
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA e31132f
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 05558e9

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 5900
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS
PULLREQUESTNUM 7904
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH topic/default_to_fpic
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA e31132f
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 05558e9

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_debug

  • Build Num: 120
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS
PULLREQUESTNUM 7904
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH topic/default_to_fpic
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA e31132f
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 05558e9

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 1936
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS
PULLREQUESTNUM 7904
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH topic/default_to_fpic
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA e31132f
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 05558e9

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 5232
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS
PULLREQUESTNUM 7904
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH topic/default_to_fpic
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA e31132f
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 05558e9

Build Information

Test Name: Trilinos_pullrequest_clang_10.0.0

  • Build Num: 381
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS
PULLREQUESTNUM 7904
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH topic/default_to_fpic
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA e31132f
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 05558e9

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 3237
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS
PULLREQUESTNUM 7904
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH topic/default_to_fpic
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA e31132f
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 05558e9

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 3258
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS
PULLREQUESTNUM 7904
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH topic/default_to_fpic
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA e31132f
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 05558e9

Using Repos:

Repo: TRILINOS (e10harvey/Trilinos)
  • Branch: topic/default_to_fpic
  • SHA: e31132f
  • Mode: TEST_REPO

Pull Request Author: e10harvey

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 7665
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PR_LABELS
PULLREQUESTNUM 7904
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH topic/default_to_fpic
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA e31132f
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 05558e9

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 7475
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS
PULLREQUESTNUM 7904
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH topic/default_to_fpic
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA e31132f
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 05558e9

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 5900
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS
PULLREQUESTNUM 7904
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH topic/default_to_fpic
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA e31132f
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 05558e9

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_debug

  • Build Num: 120
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS
PULLREQUESTNUM 7904
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH topic/default_to_fpic
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA e31132f
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 05558e9

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 1936
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS
PULLREQUESTNUM 7904
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH topic/default_to_fpic
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA e31132f
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 05558e9

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 5232
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS
PULLREQUESTNUM 7904
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH topic/default_to_fpic
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA e31132f
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 05558e9

Build Information

Test Name: Trilinos_pullrequest_clang_10.0.0

  • Build Num: 381
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS
PULLREQUESTNUM 7904
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH topic/default_to_fpic
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA e31132f
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 05558e9

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 3237
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS
PULLREQUESTNUM 7904
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH topic/default_to_fpic
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA e31132f
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 05558e9

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 3258
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS
PULLREQUESTNUM 7904
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH topic/default_to_fpic
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA e31132f
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 05558e9


CDash Test Results for PR# 7904.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@e10harvey e10harvey added the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Aug 25, 2020
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ jmgate ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester trilinos-autotester merged commit 3c3cffc into trilinos:develop Aug 25, 2020
@trilinos-autotester
Copy link
Contributor

Merge on Pull Request# 7904: IS A SUCCESS - Pull Request successfully merged

@trilinos-autotester trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Aug 25, 2020
@e10harvey e10harvey deleted the topic/default_to_fpic branch August 25, 2020 20:13
@bartlettroscoe bartlettroscoe changed the title ATDM/apps: Turn fPIC on by default ATDM/apps: Turn fPIC on by default for EMPIRE builds of Trilinos Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmgate jmgate jmgate approved these changes

Assignees

@e10harvey e10harvey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@e10harvey @trilinos-autotester @jmgate