Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tempus: Adjustments to the AppAction Interface #7559

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Tempus: Adjustments to the AppAction Interface #7559

merged 1 commit into from
Jun 30, 2020

Conversation

ccober6
Copy link
Contributor

@ccober6 ccober6 commented Jun 19, 2020

@trilinos/tempus

Motivation

The RK ModifierX interface needed the stage number, and in the BEFORE_EXPLICIT_EVAL case the stageX solution needed to be passed in for EMPIRE.

  • Moved the RK Tableau in to RKBase, along with related
    accessors, to allow access from the base class.
    • IMEX steppers return the explicit tableau from getTableau().
  • Moved getStageNumber() to RKBase.
  • Add stageNumber to the StepperRKModifierXBase interface.
  • Added RK stepper unit tests for stageNumber and stageX.
    The stageX tests were a little difficult to develop, because
    in explicit RK steppers stageX and workingState->getX are the
    same. So there is no stageX to test outside the stepper.
    Therefore direct comparisons against numerical values was used.

Miscellaneous

  • Fixed some doxygen comments.

Related Issues

Stakeholder Feedback

N/A

Testing

Added unit tests for the stage number access and for the stageX values.

@ccober6 ccober6 added type: enhancement Issue is an enhancement, not a bug pkg: Tempus client: EMPIRE All issues that most directly target the ATDM EMPIRE code AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed labels Jun 19, 2020
@ccober6 ccober6 requested review from sconde, rppawlo and asteyer June 19, 2020 16:08
@ccober6 ccober6 self-assigned this Jun 19, 2020
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

2 similar comments
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 7097
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PR_LABELS AT: AUTOMERGE;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 9824178
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 75c3d45

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 6907
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 9824178
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 75c3d45

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 5332
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 9824178
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 75c3d45

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 5179
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 9824178
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 75c3d45

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 1368
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 9824178
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 75c3d45

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 4663
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 9824178
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 75c3d45

Build Information

Test Name: Trilinos_pullrequest_clang_9.0.0

  • Build Num: 1038
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 9824178
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 75c3d45

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 2760
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 9824178
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 75c3d45

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 2769
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 9824178
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 75c3d45

Using Repos:

Repo: TRILINOS (trilinos/Trilinos)
  • Branch: 7549-Tempus-Adjustments-to-the-AppAction-Interface
  • SHA: 9824178
  • Mode: TEST_REPO

Pull Request Author: ccober6

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 7097
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PR_LABELS AT: AUTOMERGE;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 9824178
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 75c3d45

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 6907
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 9824178
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 75c3d45

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 5332
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 9824178
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 75c3d45

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 5179
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 9824178
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 75c3d45

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 1368
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 9824178
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 75c3d45

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 4663
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 9824178
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 75c3d45

Build Information

Test Name: Trilinos_pullrequest_clang_9.0.0

  • Build Num: 1038
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 9824178
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 75c3d45

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 2760
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 9824178
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 75c3d45

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 2769
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 9824178
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 75c3d45


CDash Test Results for PR# 7559.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

2 similar comments
@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@ccober6
Copy link
Contributor Author

ccober6 commented Jun 22, 2020

@asteyer @sconde @rppawlo Sorry to pester about this, but can someone review this for me? Thanks!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
THE LAST COMMIT TO THIS PULL REQUEST HAS BEEN REVIEWED, BUT NOT ACCEPTED OR REQUIRES CHANGES

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@sconde
Copy link
Contributor

sconde commented Jun 22, 2020

@ccober6 please let me know when I should review this again.

@ccober6 ccober6 force-pushed the 7549-Tempus-Adjustments-to-the-AppAction-Interface branch from 9824178 to 43b7042 Compare June 22, 2020 22:55
@ccober6
Copy link
Contributor Author

ccober6 commented Jun 22, 2020

@sconde Did a force push, so it should be ready for review. Thanks for the help!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 7126
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PR_LABELS AT: AUTOMERGE;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 43b7042
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13cc64a

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 6936
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 43b7042
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13cc64a

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 5361
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 43b7042
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13cc64a

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 5208
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 43b7042
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13cc64a

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 1397
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 43b7042
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13cc64a

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 4692
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 43b7042
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13cc64a

Build Information

Test Name: Trilinos_pullrequest_clang_9.0.0

  • Build Num: 1067
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 43b7042
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13cc64a

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 2787
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 43b7042
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13cc64a

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 2796
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 43b7042
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13cc64a

Using Repos:

Repo: TRILINOS (trilinos/Trilinos)
  • Branch: 7549-Tempus-Adjustments-to-the-AppAction-Interface
  • SHA: 43b7042
  • Mode: TEST_REPO

Pull Request Author: ccober6

sconde
sconde previously approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@sconde sconde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good on my end. Thank you for taking care of this.

@ccober6
Copy link
Contributor Author

ccober6 commented Jun 29, 2020

@sconde I made some additional fixes and restarted the testing. Can you review this for me? Sorry for the multiple reviews, but hopefully we can get this one through and I will start another issue. Thanks!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 7186
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PR_LABELS AT: AUTOMERGE;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b9b344e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13cc64a

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 6996
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b9b344e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13cc64a

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 5421
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b9b344e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13cc64a

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 5268
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b9b344e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13cc64a

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 1457
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b9b344e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13cc64a

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 4752
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b9b344e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13cc64a

Build Information

Test Name: Trilinos_pullrequest_clang_9.0.0

  • Build Num: 1127
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b9b344e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13cc64a

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 2841
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b9b344e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13cc64a

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 2850
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b9b344e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13cc64a


CDash Test Results for PR# 7559.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
THE LAST COMMIT TO THIS PULL REQUEST HAS NOT BEEN REVIEWED YET!

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 7189
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PR_LABELS AT: RETEST;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b9b344e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13cc64a

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 6999
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: RETEST;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b9b344e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13cc64a

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 5424
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: RETEST;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b9b344e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13cc64a

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 5271
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: RETEST;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b9b344e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13cc64a

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 1460
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: RETEST;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b9b344e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13cc64a

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 4755
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: RETEST;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b9b344e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13cc64a

Build Information

Test Name: Trilinos_pullrequest_clang_9.0.0

  • Build Num: 1130
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: RETEST;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b9b344e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13cc64a

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 2844
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: RETEST;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b9b344e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13cc64a

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 2853
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: RETEST;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b9b344e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13cc64a

Using Repos:

Repo: TRILINOS (trilinos/Trilinos)
  • Branch: 7549-Tempus-Adjustments-to-the-AppAction-Interface
  • SHA: b9b344e
  • Mode: TEST_REPO

Pull Request Author: ccober6

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 7189
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PR_LABELS AT: RETEST;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b9b344e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13cc64a

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 6999
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: RETEST;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b9b344e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13cc64a

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 5424
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: RETEST;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b9b344e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13cc64a

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 5271
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: RETEST;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b9b344e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13cc64a

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 1460
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: RETEST;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b9b344e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13cc64a

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 4755
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: RETEST;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b9b344e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13cc64a

Build Information

Test Name: Trilinos_pullrequest_clang_9.0.0

  • Build Num: 1130
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: RETEST;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b9b344e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13cc64a

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 2844
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: RETEST;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b9b344e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13cc64a

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 2853
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: RETEST;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b9b344e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13cc64a


CDash Test Results for PR# 7559.

@trilinos-autotester trilinos-autotester removed the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Jun 29, 2020
@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@ccober6
Copy link
Contributor Author

ccober6 commented Jun 29, 2020

@sconde I have failed to push my recent changes. Give me a few minutes to get it pushed.

@ccober6
Tempus: Adjustments to the AppAction Interface
7ba6f07 
 * Moved the RK Tableau in to RKBase, along with related
   accessors, to allow access from the base class.
    - IMEX steppers return the explicit tableau from getTableau().
 * Moved getStageNumber() to RKBase.
 * Add stageNumber to the StepperRKModifierXBase interface.
 * Added RK stepper unit tests for stageNumber and stageX.
   The stageX tests were a little difficult to develop, because
   in explicit RK steppers stageX and workingState->getX are the
   same.  So there is no stageX to test outside the stepper.
   Therefore direct comparisons against numerical values was used.
 * Added accessors to the IMEX and IMEX Partition tableaus,
   to both the explicit and implicit tableaus.
 * Added comparison operators for RKButcherTableau.
 * Added unit tests for these accessors.
 * Fix and add unit tests for StepperRKAppActionComposite.
 * Add a const version of StepperRKBase::getStageX().
 * Switch StepperRKModifierXBase::XDOT_END_STAGE to
   StepperRKModifierXBase::X_END_STAGE as that is what
   EMPIRE is using.

All tests pass on a Mac/GCC.
@ccober6 ccober6 force-pushed the 7549-Tempus-Adjustments-to-the-AppAction-Interface branch from b9b344e to 7ba6f07 Compare June 29, 2020 21:54
@ccober6
Copy link
Contributor Author

ccober6 commented Jun 29, 2020

@sconde OK already for you to review. Thanks!

@ccober6 ccober6 added the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Jun 29, 2020
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 7191
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PR_LABELS AT: RETEST;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 7ba6f07
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4874da5

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 7001
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: RETEST;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 7ba6f07
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4874da5

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 5426
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: RETEST;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 7ba6f07
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4874da5

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 5273
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: RETEST;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 7ba6f07
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4874da5

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 1462
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: RETEST;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 7ba6f07
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4874da5

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 4757
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: RETEST;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 7ba6f07
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4874da5

Build Information

Test Name: Trilinos_pullrequest_clang_9.0.0

  • Build Num: 1132
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: RETEST;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 7ba6f07
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4874da5

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 2846
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: RETEST;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 7ba6f07
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4874da5

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 2855
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: RETEST;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 7ba6f07
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4874da5

Using Repos:

Repo: TRILINOS (trilinos/Trilinos)
  • Branch: 7549-Tempus-Adjustments-to-the-AppAction-Interface
  • SHA: 7ba6f07
  • Mode: TEST_REPO

Pull Request Author: ccober6

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 7191
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PR_LABELS AT: RETEST;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 7ba6f07
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4874da5

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 7001
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: RETEST;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 7ba6f07
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4874da5

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 5426
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: RETEST;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 7ba6f07
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4874da5

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 5273
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: RETEST;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 7ba6f07
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4874da5

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 1462
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: RETEST;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 7ba6f07
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4874da5

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 4757
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: RETEST;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 7ba6f07
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4874da5

Build Information

Test Name: Trilinos_pullrequest_clang_9.0.0

  • Build Num: 1132
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: RETEST;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 7ba6f07
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4874da5

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 2846
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: RETEST;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 7ba6f07
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4874da5

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 2855
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: RETEST;client: EMPIRE;pkg: Tempus;type: enhancement
PULLREQUESTNUM 7559
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 7549-Tempus-Adjustments-to-the-AppAction-Interface
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 7ba6f07
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4874da5


CDash Test Results for PR# 7559.

@trilinos-autotester trilinos-autotester removed the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Jun 29, 2020
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
THE LAST COMMIT TO THIS PULL REQUEST HAS NOT BEEN REVIEWED YET!

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@sconde sconde self-requested a review June 30, 2020 12:15
sconde
sconde approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@sconde sconde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ sconde ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR...

@ccober6 ccober6 merged commit bd6bedc into develop Jun 30, 2020
@ccober6 ccober6 linked an issue Aug 12, 2020 that may be closed by this pull request
Tempus: Adjustments to the AppAction Interface #7549
Closed
@ccober6 ccober6 deleted the 7549-Tempus-Adjustments-to-the-AppAction-Interface branch August 13, 2020 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sconde sconde sconde approved these changes

@rppawlo rppawlo Awaiting requested review from rppawlo

@asteyer asteyer Awaiting requested review from asteyer

Assignees

@ccober6 ccober6

Labels
client: EMPIRE All issues that most directly target the ATDM EMPIRE code pkg: Tempus type: enhancement Issue is an enhancement, not a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tempus: Adjustments to the AppAction Interface
3 participants
@ccober6 @trilinos-autotester @sconde