Provide a single file MpiReleaseDebugSharedPtSerial.cmake that can be read in with cmake -C (#2462) #2609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These options were removed from the EMPIRE configuration of Trilinos in the
EM-Plamsa/BulidScripts repo as of commit:
commit 285a5a7cad924a4419ede6eccaaefe687f958fa3
Author: Jason M. Gates <jmgate@sandia.gov>
Date: Thu Mar 29 16:41:22 2018 -0600
Remove Experimental Flags
See trilinos#2467.
Therefore, we can hopefully safely assume these are not needed to help protect
EMPIRE's usage of Trilinos anymore.
This avoids duplication.
bartlettroscoe
added
Framework tasks
bartlettroscoe
requested review from
william76,
jwillenbring,
prwolfe and
fryeguy52
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Using Repos:
Pull Request Author: bartlettroscoe |
bartlettroscoe
force-pushed
the
2462-single-cmake-file
branch
from
ec01280 to
950fe4f
Compare
bartlettroscoe
changed the title
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Using Repos:
Pull Request Author: bartlettroscoe |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
2 similar comments
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Using Repos:
Pull Request Author: bartlettroscoe |
bartlettroscoe
changed the title
trilinos#2462) Now this makes it stupid easy to reproduce this particular build. You just do: source <trilinos-base-dir>/cmake/load_sems_dev_env.sh cmake -C <trilinos-base-dir>/cmake/std/MpiReleaseDebugSharedPtSerial.cmake \ -DTrilinos_ENABLE_TESTS=ON -DTrilinos_ENABLE_<PACKAGE>=ON \ <trilinos-base-dir>
This could be used, for example, for the Intel 17 build in trilinos#2463.
bartlettroscoe
force-pushed
the
2462-single-cmake-file
branch
from
b3a59be to
579a77b
Compare
|
@fryeguy52, could you please give this PR a quick review? I need someone to review this in order to merge it. |
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Using Repos:
Pull Request Author: bartlettroscoe |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ fryeguy52 ]! |
|
Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Master Automerge is disabled (in .cfg file) |
|
@fryeguy52, thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC: @trilinos/framework, @fryeguy52
Description
This is the CI build that has been running for the last 1.5+ years described at:
and this is the exact build used by the checkin-test-sems.sh script. This PR just aggregates this into a single file that can be included with
-C <abs-bas-dir>/Trilinos/cmake/std/MpiReleaseDebugSharedPtSerial.cmake.This new file
Trilinos/cmake/std/MpiReleaseDebugSharedPtSerial.cmakeis now a good candidate for the GCC 4.8.4 auto PR build in #2462. That build satisfies all of the requirements specified in #2462 and #2317, except for using OpenMP, which we can't until we can address some of #2422.I also provided the file
MpiReleaseSharedPtSerial.cmakethat could be used for the Intel build in #2463. This improve consistency and reduces duplication.This PR also removes the Xpetra and MueLu Experimental enables in commit 7481c76.
How Has This Been Tested?
I tested all of this manually locally. I run the checkin-test-sems.sh script locally and I ran
ctest -Swith the ctest driver script locally as per step 5 "Test CTest -S driver scripts" in:The auto PR tester will fire off and test everything but nothing I have changed here impacts those builds (yet).
Checklist