Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tpetra: Add "Error 127" CUDA build work-around to FAQ #2352

Merged
merged 2 commits into from
Mar 9, 2018

Conversation

mhoemmen
Copy link
Contributor

@mhoemmen mhoemmen commented Mar 8, 2018

Add work-around for "Error 127" kokkos-kernels CUDA build link error to Tpetra's FAQ.
See Trilinos/packages/tpetra/doc/FAQ.txt.
This pull request ONLY affects Tpetra's documentation.
It does not touch source code files.

@trilinos/tpetra

See the following GitHub issue:

#2141

and the following detailed instructions:

https://tribits.org/doc/TribitsBuildReference.html#enabling-the-usage-of-resource-files-to-reduce-length-of-build-lines

Thanks to @bartlettroscoe for the instructions!

@mhoemmen mhoemmen self-assigned this Mar 8, 2018
@mhoemmen mhoemmen added the stage: in progress Work on the issue has started label Mar 8, 2018
@mhoemmen mhoemmen requested review from bartlettroscoe, ibaned, crtrott, william76 and tjfulle and removed request for crtrott March 8, 2018 06:28
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_autotester_test

  • Build Num: 463
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2352
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Tpetra-FAQ-Error-127-workaround
TRILINOS_SOURCE_REPO https://github.com/mhoemmen/Trilinos
TRILINOS_SOURCE_SHA 44d886b
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 797671c

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

  • Build Num: 328
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.9.3
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2352
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Tpetra-FAQ-Error-127-workaround
TRILINOS_SOURCE_REPO https://github.com/mhoemmen/Trilinos
TRILINOS_SOURCE_SHA 44d886b
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 797671c

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 43
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2352
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Tpetra-FAQ-Error-127-workaround
TRILINOS_SOURCE_REPO https://github.com/mhoemmen/Trilinos
TRILINOS_SOURCE_SHA 44d886b
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 797671c

Using Repos:

Repo: TRILINOS (mhoemmen/Trilinos)
  • Branch: Tpetra-FAQ-Error-127-workaround
  • SHA: 44d886b
  • Mode: TEST_REPO

Pull Request Author: mhoemmen

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_autotester_test

  • Build Num: 463
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2352
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Tpetra-FAQ-Error-127-workaround
TRILINOS_SOURCE_REPO https://github.com/mhoemmen/Trilinos
TRILINOS_SOURCE_SHA 44d886b
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 797671c

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

  • Build Num: 328
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.9.3
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2352
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Tpetra-FAQ-Error-127-workaround
TRILINOS_SOURCE_REPO https://github.com/mhoemmen/Trilinos
TRILINOS_SOURCE_SHA 44d886b
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 797671c

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 43
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2352
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Tpetra-FAQ-Error-127-workaround
TRILINOS_SOURCE_REPO https://github.com/mhoemmen/Trilinos
TRILINOS_SOURCE_SHA 44d886b
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 797671c

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

Copy link
Contributor

@ibaned ibaned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

Copy link
Member

@bartlettroscoe bartlettroscoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Short answer: Try setting the following CMake option:
#+BEGIN_EXAMPLE
CMAKE_CXX_USE_RESPONSE_FILE_FOR_OBJECTS:BOOL=ON
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to add the -D prefix as:

-D CMAKE_CXX_USE_RESPONSE_FILE_FOR_OBJECTS:BOOL=ON

Just a suggestion for people who might actually try to just pass in CMAKE_CXX_USE_RESPONSE_FILE_FOR_OBJECTS:BOOL=ON to the cmake comamnd.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done (locally)


and the following instructions:

https://tribits.org/doc/TribitsBuildReference.html#enabling-the-usage-of-resource-files-to-reduce-length-of-build-lines
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, once TriBITS is snapshotted into Trilinos, you should point into the Trilinos Build reference document instead of this generic one.

I was going to add another thing to TriBITS before I snaphsotted it into Trilinos but I will go ahead and do that now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just pushed the commit afed21c that should bring this documentation into the document:

the next time the Trilinos Framework script runs that rebuilds this document. (You will have to ask @jwillenbring when that occurs.)

So you should likely change this to point to:

instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bartlettroscoe Cool, thanks Ross! I'll make those changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bartlettroscoe btw, trilinos.org gives me the nastygram about having a bad certificate; may I also point to the other link as a back-up?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trilinos.org gives me the nastygram about having a bad certificate; may I also point to the other link as a back-up?

Ya, I know. I told the @trilinos/framework team about this a while back. You can check with @jwillenbring about the progress on fixing that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done (locally)

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
THE LAST COMMIT TO THIS PULL REQUEST HAS BEEN REVIEWED, BUT NOT ACCEPTED OR REQUIRES CHANGES

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@mhoemmen
Copy link
Contributor Author

mhoemmen commented Mar 8, 2018

I'll mark this as [WIP] temporarily so the autotester doesn't bother y'all.

@mhoemmen mhoemmen changed the title Tpetra: Add "Error 127" CUDA build work-around to FAQ [WIP] Tpetra: Add "Error 127" CUDA build work-around to FAQ Mar 8, 2018
@mhoemmen mhoemmen added the AT: WIP Causes the PR autotester to not test the PR. (Remove to allow testing to occur.) label Mar 8, 2018
@trilinos/tpetra I implemented @bartlettroscoe's suggested changes.
@mhoemmen mhoemmen removed the AT: WIP Causes the PR autotester to not test the PR. (Remove to allow testing to occur.) label Mar 9, 2018
@mhoemmen mhoemmen changed the title [WIP] Tpetra: Add "Error 127" CUDA build work-around to FAQ Tpetra: Add "Error 127" CUDA build work-around to FAQ Mar 9, 2018
@mhoemmen mhoemmen merged commit 1e1255a into trilinos:develop Mar 9, 2018
@mhoemmen mhoemmen removed the stage: in progress Work on the issue has started label Mar 9, 2018
@mhoemmen
Copy link
Contributor Author

mhoemmen commented Mar 9, 2018

Thanks all!

lucbv pushed a commit to lucbv/Trilinos that referenced this pull request Mar 9, 2018
Add work-around for "Error 127" kokkos-kernels CUDA build link error to Tpetra's FAQ.
See Trilinos/packages/tpetra/doc/FAQ.txt.
This commit ONLY affects Tpetra's documentation.
It does not touch source code files.

@trilinos/tpetra

See the following GitHub issue:

trilinos#2141

and the following detailed instructions:

https://tribits.org/doc/TribitsBuildReference.html#enabling-the-usage-of-resource-files-to-reduce-length-of-build-lines

Thanks to @bartlettroscoe for the instructions!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants