Kokkos + KokkosKernels Promotion To 4.4.0 #13334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndellingwood
changed the title
This was referenced Aug 8, 2024
ndellingwood
force-pushed
the
kokkos-promotion
branch
2 times, most recently
from
0dde5a5 to
6ad870b
Compare
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
Using Repos:
Pull Request Author: ndellingwood |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
|
|
Looks good to me, we are incorporating the stk change into the sierra/stk repo. |
alanw0
previously approved these changes
Aug 8, 2024
|
From cdash: Compilation errors with -Werror=sign-compare in the gcc/8.5.0 builds:
The rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables job posted unit test failure in |
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
Using Repos:
Pull Request Author: ndellingwood |
|
Re: the rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables job failure in TrilinosInstallTests_doInstall reporting: This also occurred in #13332 with unrelated changes. The job referenced above also did not post any compilation errors. @trilinos/framework @sebrowne can you help us understand the underlying issue? Edit: adding link to the cdash job rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables referred to above |
|
Build errors are showing up for Tacho in the latest round of testing https://trilinos-cdash.sandia.gov/viewBuildError.php?buildid=1778541 , those errors are due to Maybe there was a change to the CI config flags after #13318 was submitted and passed testing, and so the unused variables were not flagged in that PR? |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
|
ndellingwood
added
the
AT: WIP
|
@ndellingwood yes new flags were introduced in #13308 and merged into develop late afternoon yesterday. #13318 passed its AutoTester run a day prior to the new flags being introduced, but got merged only yesterday :( |
ndellingwood
force-pushed
the
kokkos-promotion
branch
from
376f854 to
3e1f575
Compare
dalg24
approved these changes
Aug 9, 2024
lucbv
approved these changes
Aug 9, 2024
modify NgpMeshTest.volatileFastSharedCommMap to prevent allocation in a parallel region, which can result in deadlock with kokkos version 4.4 address issue #13328 Co-authored-by: Christian Trott <crtrott@sandia.gov> Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>
…9e3105
From repository at git@github.com:kokkos/kokkos.git
At commit:
commit 948c1346301ff9b42b136a8c72eed91c839e3105
Author: Nathan Ellingwood <ndellin@sandia.gov>
Date: Thu Aug 8 14:54:40 2024 -0600
update master_history.txt for 4.4.00
Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>
…35ce52331646bb
From repository at git@github.com:kokkos/kokkos-kernels.git
At commit:
commit 630a58d5f34e8f1c3c587d45c735ce52331646bb
Author: Nathan Ellingwood <ndellin@sandia.gov>
Date: Thu Aug 8 15:29:27 2024 -0600
update master_history.txt for 4.4.00
Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>
Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>
ndellingwood
force-pushed
the
kokkos-promotion
branch
from
4e4b468 to
2095d65
Compare
ndellingwood
removed
the
AT: WIP
|
Rebased on top of develop with merge of #13337 , ready to retest |
lucbv
approved these changes
Aug 9, 2024
|
It looks like AT-2 is adding tests when I submit a review but not canceling out old ones it already started? |
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
Using Repos:
Pull Request Author: ndellingwood |
dalg24
approved these changes
Aug 10, 2024
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ lucbv ]! |
|
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
crtrott
approved these changes
Aug 10, 2024
|
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
1 similar comment
|
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
|
Could we please move forward and merge? |
|
@dalg24 merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trilinos/kokkos @trilinos/kokkos-kernels
Motivation
Snapshot Kokkos Ecosystem 4.4.0 to Trilinos
Related Issues
NgpMeshTest.volatileFastSharedCommMapsubtest with kokkos release-candidate-4.4.00 #13328@alanw0 @ldh4 - the sha should be easy to cherry-pick to the the stk repo, if that change is acceptable
Testing
Various nightly testing jobs of release candidate, AT will handle the rest