KokkosKernels: temp. fix for #11655 #11663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Temporary) In SpGEMM, disable the check that the input matrices are sorted if the KokkosKernels (non-TPL) implementation is going to be called. This impl does not actually require sorted inputs, and Tpetra's MatrixMatrix logic needs some nontrivial changes to have a sorted B.
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_PR_gcc-8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_gcc-8.3.0-serial
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_gcc-8.3.0-debug
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_clang-11.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_cuda-11.4.2-uvm-off
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_intel-2021.3
Jenkins Parameters
Using Repos:
Pull Request Author: brian-kelley |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_PR_gcc-8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_gcc-8.3.0-serial
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_gcc-8.3.0-debug
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_clang-11.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_cuda-11.4.2-uvm-off
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_intel-2021.3
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ cgcgcg ]! |
|
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
2 similar comments
|
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
|
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
rppawlo
approved these changes
Mar 13, 2023
|
Thanks @brian-kelley and @cgcgcg ! |
|
@brian-kelley can you submit a matching patch to kokkos-kernels? I'll cherry-pick for the 4.0.01 patch release |
|
@ndellingwood Hmm... I was hoping this could just be a short-term change that could be reverted soon. It's really a workaround for a Tpetra issue that evaded testing, rather than a KokkosKernels issue. When are you planning to put together the 4.0.1 release candidate? Depending on that I will either patch to KK, or go for the permanent fix in Tpetra and (at the same time) revert this PR. |
@brian-kelley thanks for the update, I hadn't realized that. No ETA on a 4.0.01 patch yet, I'll check in the kokkos meeting this week. I'll check back in with you closer to snapshot time with 4.0.01, if I don't see a PR to Tpetra with the long-term fix we can coordinate the patch to eventual release candidate branch |
brian-kelley
added a commit
to brian-kelley/Trilinos
that referenced
this pull request
Mar 22, 2023
This was referenced Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Temporary) In SpGEMM, disable the check that the input matrices are sorted if the KokkosKernels (non-TPL) implementation is going to be called. This impl does not actually require sorted inputs. Tpetra's MatrixMatrix::Multiply logic needs some nontrivial changes to have a sorted B, but that will be the long-term fix for #11655.
@trilinos/kokkos-kernels
@trilinos/tpetra
Motivation
With this change, all Panzer-MiniEM tests pass in an OpenMP+Debug build (develop branch had 6 failures).
Stakeholder Feedback
Testing