Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove listing of undefined TPL deps (#11152) #11154

Conversation

bartlettroscoe
Copy link
Member

@bartlettroscoe bartlettroscoe commented Oct 17, 2022

Updated TriBITS 'master' now catches undefined TPLs listed as dependencies of
a TriBITS package.  (Amazingly, classic TriBITS simply silently ignored these
undefined TPLs.  See tribits/CHANGELOG.md entry in TriBITSPub/TriBITS#530.)

This works with older TriBITS and will be needed when TriBITS 'master' is
snapshotted into Trilinos 'develop'.
Updated TriBITS 'master' now catches undefined TPLs listed as dependencies of
a TriBITS package.  (Amazingly, classic TriBITS simply silently ignored these
undefined TPLs.  See tribits/CHANGELOG.md entry in TriBITSPub/TriBITS#530.)

This works with older TriBITS and will be needed when TriBITS 'master' is
snapshotted into Trilinos 'develop'.
Updated TriBITS 'master' now catches undefined TPLs listed as dependencies of
a TriBITS package.  (Amazingly, classic TriBITS simply silently ignored these
undefined TPLs.  See tribits/CHANGELOG.md entry in TriBITSPub/TriBITS#530.)

This works with older TriBITS and will be needed when TriBITS 'master' is
snapshotted into Trilinos 'develop'.
Updated TriBITS 'master' now catches undefined TPLs listed as dependencies of
a TriBITS package.  (Amazingly, classic TriBITS simply silently ignored these
undefined TPLs.  See tribits/CHANGELOG.md entry in TriBITSPub/TriBITS#530.)

This works with older TriBITS and will be needed when TriBITS 'master' is
snapshotted into Trilinos 'develop'.
Updated TriBITS 'master' now catches undefined TPLs listed as dependencies of
a TriBITS package.  (Amazingly, classic TriBITS simply silently ignored these
undefined TPLs.  See tribits/CHANGELOG.md entry in TriBITSPub/TriBITS#530.)

This works with older TriBITS and will be needed when TriBITS 'master' is
snapshotted into Trilinos 'develop'.
Updated TriBITS 'master' now catches undefined TPLs listed as dependencies of
a TriBITS package.  (Amazingly, classic TriBITS simply silently ignored these
undefined TPLs.  See tribits/CHANGELOG.md entry in TriBITSPub/TriBITS#530.)

This works with older TriBITS and will be needed when TriBITS 'master' is
snapshotted into Trilinos 'develop'.
@bartlettroscoe bartlettroscoe self-assigned this Oct 17, 2022
@bartlettroscoe bartlettroscoe requested a review from a team as a code owner October 17, 2022 21:49
@bartlettroscoe bartlettroscoe added the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Oct 17, 2022
@bartlettroscoe
Copy link
Member Author

Can someone please approve ASAP? Getting this merged will fix Charon Trilinos integration.

NOTE: this works with both old and new TriBITS so this PR should be merged now even before the update of TriBITS snapshot into Trilinos 'develop'.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

  • Build Num: 1260
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Kokkos;pkg: seacas;pkg: Zoltan2;pkg: Rythmos;pkg: Zoltan;pkg: KokkosKernels;AT: AUTOMERGE;PA: Framework
PULLREQUESTNUM 11154
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH 11152-remove-undefined-tpl-deps
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA da02d7e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 107dfc4

Build Information

Test Name: Trilinos_PR_gcc-7.2.0-serial

  • Build Num: 1260
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-7.2.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Kokkos;pkg: seacas;pkg: Zoltan2;pkg: Rythmos;pkg: Zoltan;pkg: KokkosKernels;AT: AUTOMERGE;PA: Framework
PULLREQUESTNUM 11154
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH 11152-remove-undefined-tpl-deps
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA da02d7e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 107dfc4

Build Information

Test Name: Trilinos_PR_gcc-7.2.0-debug

  • Build Num: 1257
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-7.2.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Kokkos;pkg: seacas;pkg: Zoltan2;pkg: Rythmos;pkg: Zoltan;pkg: KokkosKernels;AT: AUTOMERGE;PA: Framework
PULLREQUESTNUM 11154
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH 11152-remove-undefined-tpl-deps
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA da02d7e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 107dfc4

Build Information

Test Name: Trilinos_PR_intel-17.0.1

  • Build Num: 1257
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-intel-17.0.1-mpich-3.2-serial_release-debug_static_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Kokkos;pkg: seacas;pkg: Zoltan2;pkg: Rythmos;pkg: Zoltan;pkg: KokkosKernels;AT: AUTOMERGE;PA: Framework
PULLREQUESTNUM 11154
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH 11152-remove-undefined-tpl-deps
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA da02d7e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 107dfc4

Build Information

Test Name: Trilinos_PR_clang-10.0.0

  • Build Num: 1273
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-clang-10.0.0-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Kokkos;pkg: seacas;pkg: Zoltan2;pkg: Rythmos;pkg: Zoltan;pkg: KokkosKernels;AT: AUTOMERGE;PA: Framework
PULLREQUESTNUM 11154
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH 11152-remove-undefined-tpl-deps
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA da02d7e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 107dfc4

Build Information

Test Name: Trilinos_PR_cuda-10.1.243

  • Build Num: 1275
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME ats2_cuda-10.1.243-gnu-8.3.1-spmpi-rolling_release_static_Volta70_Power9_no-asan_no-complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Kokkos;pkg: seacas;pkg: Zoltan2;pkg: Rythmos;pkg: Zoltan;pkg: KokkosKernels;AT: AUTOMERGE;PA: Framework
PULLREQUESTNUM 11154
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL vortex
TRILINOS_SOURCE_BRANCH 11152-remove-undefined-tpl-deps
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA da02d7e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 107dfc4

Build Information

Test Name: Trilinos_PR_python3

  • Build Num: 1064
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS pkg: Kokkos;pkg: seacas;pkg: Zoltan2;pkg: Rythmos;pkg: Zoltan;pkg: KokkosKernels;AT: AUTOMERGE;PA: Framework
PULLREQUESTNUM 11154
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL ascic
TRILINOS_SOURCE_BRANCH 11152-remove-undefined-tpl-deps
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA da02d7e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 107dfc4

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

  • Build Num: 794
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Kokkos;pkg: seacas;pkg: Zoltan2;pkg: Rythmos;pkg: Zoltan;pkg: KokkosKernels;AT: AUTOMERGE;PA: Framework
PULLREQUESTNUM 11154
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL GPU
TRILINOS_SOURCE_BRANCH 11152-remove-undefined-tpl-deps
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA da02d7e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 107dfc4

Using Repos:

Repo: TRILINOS (bartlettroscoe/Trilinos)
  • Branch: 11152-remove-undefined-tpl-deps
  • SHA: da02d7e
  • Mode: TEST_REPO

Pull Request Author: bartlettroscoe

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

  • Build Num: 1260
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Kokkos;pkg: seacas;pkg: Zoltan2;pkg: Rythmos;pkg: Zoltan;pkg: KokkosKernels;AT: AUTOMERGE;PA: Framework
PULLREQUESTNUM 11154
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH 11152-remove-undefined-tpl-deps
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA da02d7e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 107dfc4

Build Information

Test Name: Trilinos_PR_gcc-7.2.0-serial

  • Build Num: 1260
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-7.2.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Kokkos;pkg: seacas;pkg: Zoltan2;pkg: Rythmos;pkg: Zoltan;pkg: KokkosKernels;AT: AUTOMERGE;PA: Framework
PULLREQUESTNUM 11154
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH 11152-remove-undefined-tpl-deps
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA da02d7e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 107dfc4

Build Information

Test Name: Trilinos_PR_gcc-7.2.0-debug

  • Build Num: 1257
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-7.2.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Kokkos;pkg: seacas;pkg: Zoltan2;pkg: Rythmos;pkg: Zoltan;pkg: KokkosKernels;AT: AUTOMERGE;PA: Framework
PULLREQUESTNUM 11154
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH 11152-remove-undefined-tpl-deps
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA da02d7e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 107dfc4

Build Information

Test Name: Trilinos_PR_intel-17.0.1

  • Build Num: 1257
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-intel-17.0.1-mpich-3.2-serial_release-debug_static_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Kokkos;pkg: seacas;pkg: Zoltan2;pkg: Rythmos;pkg: Zoltan;pkg: KokkosKernels;AT: AUTOMERGE;PA: Framework
PULLREQUESTNUM 11154
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH 11152-remove-undefined-tpl-deps
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA da02d7e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 107dfc4

Build Information

Test Name: Trilinos_PR_clang-10.0.0

  • Build Num: 1273
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-clang-10.0.0-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Kokkos;pkg: seacas;pkg: Zoltan2;pkg: Rythmos;pkg: Zoltan;pkg: KokkosKernels;AT: AUTOMERGE;PA: Framework
PULLREQUESTNUM 11154
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH 11152-remove-undefined-tpl-deps
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA da02d7e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 107dfc4

Build Information

Test Name: Trilinos_PR_cuda-10.1.243

  • Build Num: 1275
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME ats2_cuda-10.1.243-gnu-8.3.1-spmpi-rolling_release_static_Volta70_Power9_no-asan_no-complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Kokkos;pkg: seacas;pkg: Zoltan2;pkg: Rythmos;pkg: Zoltan;pkg: KokkosKernels;AT: AUTOMERGE;PA: Framework
PULLREQUESTNUM 11154
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL vortex
TRILINOS_SOURCE_BRANCH 11152-remove-undefined-tpl-deps
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA da02d7e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 107dfc4

Build Information

Test Name: Trilinos_PR_python3

  • Build Num: 1064
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS pkg: Kokkos;pkg: seacas;pkg: Zoltan2;pkg: Rythmos;pkg: Zoltan;pkg: KokkosKernels;AT: AUTOMERGE;PA: Framework
PULLREQUESTNUM 11154
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL ascic
TRILINOS_SOURCE_BRANCH 11152-remove-undefined-tpl-deps
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA da02d7e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 107dfc4

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

  • Build Num: 794
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Kokkos;pkg: seacas;pkg: Zoltan2;pkg: Rythmos;pkg: Zoltan;pkg: KokkosKernels;AT: AUTOMERGE;PA: Framework
PULLREQUESTNUM 11154
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL GPU
TRILINOS_SOURCE_BRANCH 11152-remove-undefined-tpl-deps
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA da02d7e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 107dfc4


CDash Test Results for PR# 11154.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@bartlettroscoe bartlettroscoe added AT: WIP Causes the PR autotester to not test the PR. (Remove to allow testing to occur.) and removed AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed labels Oct 18, 2022
Copy link
Contributor

@ndellingwood ndellingwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on kokkos and kokkos-kernels changes (PRs with matching changes to the respective repos have been approved as well)

@bartlettroscoe I'd prefer to hold off the merge of this PR until kokkos/kokkos-kernels#1568 completes CI if that is okay (the changes should have no impact on standalone kokkos-kernels testing, but I'll feel better once the testing completes)

@ndellingwood
Copy link
Contributor

PR kokkos/kokkos-kernels#1568 merged into kokkos-kernels, thanks @bartlettroscoe !

@bartlettroscoe bartlettroscoe added AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed and removed AT: WIP Causes the PR autotester to not test the PR. (Remove to allow testing to occur.) labels Oct 18, 2022
Copy link
Member Author

@bartlettroscoe bartlettroscoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is okay to merge. See my comment in https://github.com/trilinos/Trilinos/pull/11154/files#r998765365.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ ndellingwood ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester trilinos-autotester merged commit 118436c into trilinos:develop Oct 19, 2022
@trilinos-autotester
Copy link
Contributor

Merge on Pull Request# 11154: IS A SUCCESS - Pull Request successfully merged

@trilinos-autotester trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants