Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intrepid2: Fix some shadow variable warnings #11142

Merged

Conversation

japlews
Copy link
Contributor

@japlews japlews commented Oct 13, 2022

@trilinos/intrepid2

Motivation

Fix shadow warnings that show up in Sierra builds, caused by some new headers in Intrepid2

@CamelliaDPG @mperego

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

@mperego mperego added the AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. label Oct 13, 2022
@trilinos-autotester trilinos-autotester removed the AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. label Oct 13, 2022
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; This inspection will remain valid until a new commit to source branch is performed.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

  • Build Num: 1247
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 11142
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH japlews/intrepid2-shadow-variables
TRILINOS_SOURCE_REPO https://github.com/japlews/Trilinos
TRILINOS_SOURCE_SHA aca002e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1500162

Build Information

Test Name: Trilinos_PR_gcc-7.2.0-serial

  • Build Num: 1247
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-7.2.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 11142
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH japlews/intrepid2-shadow-variables
TRILINOS_SOURCE_REPO https://github.com/japlews/Trilinos
TRILINOS_SOURCE_SHA aca002e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1500162

Build Information

Test Name: Trilinos_PR_gcc-7.2.0-debug

  • Build Num: 1244
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-7.2.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 11142
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH japlews/intrepid2-shadow-variables
TRILINOS_SOURCE_REPO https://github.com/japlews/Trilinos
TRILINOS_SOURCE_SHA aca002e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1500162

Build Information

Test Name: Trilinos_PR_intel-17.0.1

  • Build Num: 1244
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-intel-17.0.1-mpich-3.2-serial_release-debug_static_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 11142
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH japlews/intrepid2-shadow-variables
TRILINOS_SOURCE_REPO https://github.com/japlews/Trilinos
TRILINOS_SOURCE_SHA aca002e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1500162

Build Information

Test Name: Trilinos_PR_clang-10.0.0

  • Build Num: 1260
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-clang-10.0.0-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 11142
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH japlews/intrepid2-shadow-variables
TRILINOS_SOURCE_REPO https://github.com/japlews/Trilinos
TRILINOS_SOURCE_SHA aca002e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1500162

Build Information

Test Name: Trilinos_PR_cuda-10.1.243

  • Build Num: 1262
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME ats2_cuda-10.1.243-gnu-8.3.1-spmpi-rolling_release_static_Volta70_Power9_no-asan_no-complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 11142
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL vortex
TRILINOS_SOURCE_BRANCH japlews/intrepid2-shadow-variables
TRILINOS_SOURCE_REPO https://github.com/japlews/Trilinos
TRILINOS_SOURCE_SHA aca002e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1500162

Build Information

Test Name: Trilinos_PR_python3

  • Build Num: 1052
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS
PULLREQUESTNUM 11142
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL ascic
TRILINOS_SOURCE_BRANCH japlews/intrepid2-shadow-variables
TRILINOS_SOURCE_REPO https://github.com/japlews/Trilinos
TRILINOS_SOURCE_SHA aca002e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1500162

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

  • Build Num: 781
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 11142
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL GPU
TRILINOS_SOURCE_BRANCH japlews/intrepid2-shadow-variables
TRILINOS_SOURCE_REPO https://github.com/japlews/Trilinos
TRILINOS_SOURCE_SHA aca002e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1500162

Using Repos:

Repo: TRILINOS (japlews/Trilinos)
  • Branch: japlews/intrepid2-shadow-variables
  • SHA: aca002e
  • Mode: TEST_REPO

Pull Request Author: japlews

Copy link
Contributor

@CamelliaDPG CamelliaDPG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Thanks, @japlews!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

  • Build Num: 1247
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 11142
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH japlews/intrepid2-shadow-variables
TRILINOS_SOURCE_REPO https://github.com/japlews/Trilinos
TRILINOS_SOURCE_SHA aca002e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1500162

Build Information

Test Name: Trilinos_PR_gcc-7.2.0-serial

  • Build Num: 1247
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-7.2.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 11142
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH japlews/intrepid2-shadow-variables
TRILINOS_SOURCE_REPO https://github.com/japlews/Trilinos
TRILINOS_SOURCE_SHA aca002e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1500162

Build Information

Test Name: Trilinos_PR_gcc-7.2.0-debug

  • Build Num: 1244
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-7.2.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 11142
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH japlews/intrepid2-shadow-variables
TRILINOS_SOURCE_REPO https://github.com/japlews/Trilinos
TRILINOS_SOURCE_SHA aca002e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1500162

Build Information

Test Name: Trilinos_PR_intel-17.0.1

  • Build Num: 1244
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-intel-17.0.1-mpich-3.2-serial_release-debug_static_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 11142
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH japlews/intrepid2-shadow-variables
TRILINOS_SOURCE_REPO https://github.com/japlews/Trilinos
TRILINOS_SOURCE_SHA aca002e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1500162

Build Information

Test Name: Trilinos_PR_clang-10.0.0

  • Build Num: 1260
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-clang-10.0.0-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 11142
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH japlews/intrepid2-shadow-variables
TRILINOS_SOURCE_REPO https://github.com/japlews/Trilinos
TRILINOS_SOURCE_SHA aca002e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1500162

Build Information

Test Name: Trilinos_PR_cuda-10.1.243

  • Build Num: 1262
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME ats2_cuda-10.1.243-gnu-8.3.1-spmpi-rolling_release_static_Volta70_Power9_no-asan_no-complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 11142
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL vortex
TRILINOS_SOURCE_BRANCH japlews/intrepid2-shadow-variables
TRILINOS_SOURCE_REPO https://github.com/japlews/Trilinos
TRILINOS_SOURCE_SHA aca002e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1500162

Build Information

Test Name: Trilinos_PR_python3

  • Build Num: 1052
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS
PULLREQUESTNUM 11142
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL ascic
TRILINOS_SOURCE_BRANCH japlews/intrepid2-shadow-variables
TRILINOS_SOURCE_REPO https://github.com/japlews/Trilinos
TRILINOS_SOURCE_SHA aca002e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1500162

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

  • Build Num: 781
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 11142
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL GPU
TRILINOS_SOURCE_BRANCH japlews/intrepid2-shadow-variables
TRILINOS_SOURCE_REPO https://github.com/japlews/Trilinos
TRILINOS_SOURCE_SHA aca002e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 1500162


CDash Test Results for PR# 11142.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ CamelliaDPG ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR...

2 similar comments
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR...

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR...

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR...

@mperego mperego merged commit 3428aa2 into trilinos:develop Oct 17, 2022
jmgate pushed a commit to tcad-charon/Trilinos that referenced this pull request Oct 18, 2022
…s:develop' (d9299d4).

* trilinos-develop:
  Intrepid2: Fix some shadow variable warnings (trilinos#11142)
  Geminga: Pass max-stracktrace to Valgrind to avoid Intrepid2 issues
  rol: remove volatile from join in ROL_TpetraBoundConstraint.hpp
  Changes:
jmgate pushed a commit to tcad-charon/Trilinos that referenced this pull request Oct 18, 2022
…s:develop' (d9299d4).

* trilinos-develop:
  Intrepid2: Fix some shadow variable warnings (trilinos#11142)
  MueLu: Update to fix additional MueLu linking
  Geminga: Pass max-stracktrace to Valgrind to avoid Intrepid2 issues
  rol: remove volatile from join in ROL_TpetraBoundConstraint.hpp
  Changes:
jmgate pushed a commit to tcad-charon/Trilinos that referenced this pull request Oct 18, 2022
…s:develop' (d9299d4).

* trilinos-develop:
  Intrepid2: Fix some shadow variable warnings (trilinos#11142)
  MueLu: Update to fix additional MueLu linking
  Geminga: Pass max-stracktrace to Valgrind to avoid Intrepid2 issues
  rol: remove volatile from join in ROL_TpetraBoundConstraint.hpp
  Changes:
jmgate pushed a commit to tcad-charon/Trilinos that referenced this pull request Oct 18, 2022
…s:develop' (d9299d4).

* trilinos-develop:
  Intrepid2: Fix some shadow variable warnings (trilinos#11142)
  MueLu: Update to fix additional MueLu linking
  Geminga: Pass max-stracktrace to Valgrind to avoid Intrepid2 issues
  rol: remove volatile from join in ROL_TpetraBoundConstraint.hpp
  Changes:
jmgate pushed a commit to tcad-charon/Trilinos that referenced this pull request Oct 18, 2022
…s:develop' (d9299d4).

* trilinos-develop:
  Intrepid2: Fix some shadow variable warnings (trilinos#11142)
  MueLu: Update to fix additional MueLu linking
  Geminga: Pass max-stracktrace to Valgrind to avoid Intrepid2 issues
  rol: remove volatile from join in ROL_TpetraBoundConstraint.hpp
  Changes:
jmgate pushed a commit to tcad-charon/Trilinos that referenced this pull request Oct 18, 2022
…s:develop' (d9299d4).

* trilinos-develop:
  Intrepid2: Fix some shadow variable warnings (trilinos#11142)
  MueLu: Update to fix additional MueLu linking
  Geminga: Pass max-stracktrace to Valgrind to avoid Intrepid2 issues
  rol: remove volatile from join in ROL_TpetraBoundConstraint.hpp
  Changes:
@japlews japlews deleted the japlews/intrepid2-shadow-variables branch December 22, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants