CLOSED: Improve TrilinosInstallTests to make more clear (#10896) #10911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the confusion by a Trilinos developer that creatd issue trilinos#10896, I have improved these installation tests in the following way: * Made it clear that the doInstall test will fail if there are **any** build errors in the project * Print out the install errors to make it clear why the install failed * Use CTest test fixtures to skip the find_package(Trilinos) and simpleBuildAgainstTrilinos tests if the doInstall test fails
bartlettroscoe
added
the
PA: Framework
|
Shoot, this turned out to be an odd-numbered PR so it will not get tested. Closing and will open a new PR. |
bartlettroscoe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate of #10897 but with an even-numbered PR ID so it will get run by the PR tester (see #10858 (comment)) :-)