Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ats2 xl build failing starting 2021-02-10 #8756

Closed
e10harvey opened this issue Feb 15, 2021 · 5 comments
Closed

ats2 xl build failing starting 2021-02-10 #8756

e10harvey opened this issue Feb 15, 2021 · 5 comments
Assignees
Labels
ATDM Sev: Critical Problems that critically damage ability to run ATDM Trilinos builds much less allow APP updates impacting: configure or build The issue is primarily related to configuring or building PA: Framework Issues that fall under the Trilinos Framework Product Area pkg: ForTrilinos Primary Build Added by triager to mark failures affecting primary builds type: bug The primary issue is a bug in Trilinos code or tests

Comments

@e10harvey
Copy link
Contributor

CC: @trilinos/framework, @jwillenbring (Trilinos Framework Product Lead), @bartlettroscoe

Next Action Status

Description

As shown in this query the builds:

  • Trilinos-atdm-ats2-xl-2020.03.18_spmpi-rolling_serial_static_opt
  • Trilinos-atdm-ats2-xl-2020.03.18_spmpi-rolling_serial_static_dbg

started failing on testing day 2021-02-10.

All of the builds are show the following configure output like shown here:

CMake Error at /path/to/tpls/cmake/cmake-3.18.0/share/cmake/Modules/CMakeTestCXXCompiler.cmake:59 (message):
  The C++ compiler

    "/path/to/jenkins/Trilinos-atdm-ats2-xl-2020.03.18_spmpi-rolling_serial_static_opt/SRC_AND_BUILD/BUILD/build_stat_cxx_wrapper.sh"

  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: /path/to/jenkins/Trilinos-atdm-ats2-xl-2020.03.18_spmpi-rolling_serial_static_opt/SRC_AND_BUILD/BUILD/CMakeFiles/CMakeTmp

    Run Build Command(s):/path/to/bin/gmake cmTC_71648/fast && /path/to/bin/gmake  -f CMakeFiles/cmTC_71648.dir/build.make CMakeFiles/cmTC_71648.dir/build
    gmake[1]: Entering directory '/path/to/jenkins/Trilinos-atdm-ats2-xl-2020.03.18_spmpi-rolling_serial_static_opt/SRC_AND_BUILD/BUILD/CMakeFiles/CMakeTmp'
    Building CXX object CMakeFiles/cmTC_71648.dir/testCXXCompiler.cxx.o
    /path/to/jenkins/Trilinos-atdm-ats2-xl-2020.03.18_spmpi-rolling_serial_static_opt/SRC_AND_BUILD/BUILD/build_stat_cxx_wrapper.sh -x c++   -ccbin xlc++ -qxflag=disable__cplusplusOverride   -std=gnu++14 -o CMakeFiles/cmTC_71648.dir/testCXXCompiler.cxx\
.o -c /path/to/jenkins/Trilinos-atdm-ats2-xl-2020.03.18_spmpi-rolling_serial_static_opt/SRC_AND_BUILD/BUILD/CMakeFiles/CMakeTmp/testCXXCompiler.cxx
    /path/to/tpls/xl/xl-2020.03.18/xlC/16.1.1/bin/.orig/xlC_r: warning: 1501-216 command option -bin is not recognized - passed to ld
    /path/to/tpls/xl/xl-2020.03.18/xlC/16.1.1/bin/.orig/xlC_r: warning: 1501-228 input file xlc++ not found
    gmake[1]: *** [CMakeFiles/cmTC_71648.dir/build.make:85: CMakeFiles/cmTC_71648.dir/testCXXCompiler.cxx.o] Error 252
    gmake[1]: *** Deleting file 'CMakeFiles/cmTC_71648.dir/testCXXCompiler.cxx.o'
    gmake[1]: Leaving directory '/path/to/jenkins/Trilinos-atdm-ats2-xl-2020.03.18_spmpi-rolling_serial_static_opt/SRC_AND_BUILD/BUILD/CMakeFiles/CMakeTmp'
    gmake: *** [Makefile:140: cmTC_71648/fast] Error 2

Current Status on CDash

Run the above query adjusting the "Begin" and "End" dates to match today any other date range or just click "CURRENT" in the top bar to see results for the current testing day.

Steps to Reproduce

One should be able to reproduce this failure as described in:

and the system-specific instructions at:

Just log into any of the associated machines and copy and paste the full CDash build name <build-name> listed above and run commands like:

$ cd <some_build_dir>/

$ source $TRILINOS_DIR/cmake/std/atdm/load-env.sh <build-name>

$ cmake \
 -GNinja \
 -DTrilinos_CONFIGURE_OPTIONS_FILE:STRING=cmake/std/atdm/ATDMDevEnv.cmake \
 -DTrilinos_ENABLE_TESTS=ON -DTrilinos_ENABLE_<package-name>=ON \
 $TRILINOS_DIR

$ make NP=16

$ <command-to-run-on-compute-node> ctest -j4

where <package-name> is any package that you want to enable to reproduce build and/or test results.

Again, for exact system-specific details on what commands to run to build and run tests, see:

If you can't figure out what commands to run to reproduce the problem given this documentation, then please post a comment here and we will give you the exact minimal commands.

@e10harvey e10harvey added type: bug The primary issue is a bug in Trilinos code or tests pkg: ForTrilinos impacting: configure or build The issue is primarily related to configuring or building ATDM Sev: Critical Problems that critically damage ability to run ATDM Trilinos builds much less allow APP updates PA: Framework Issues that fall under the Trilinos Framework Product Area Primary Build Added by triager to mark failures affecting primary builds labels Feb 15, 2021
@bartlettroscoe
Copy link
Member

This is likely due to the upgrade to C++14 and/or the Kokkos upgrade. The XL builds were running just fine before that as shown here.

@e10harvey
Copy link
Contributor Author

@jwillenbring: Who is the assignee for this?

@prwolfe prwolfe self-assigned this Feb 22, 2021
@prwolfe
Copy link
Contributor

prwolfe commented Feb 22, 2021

@jwillenbring: Who is the assignee for this?

I am taking this as we discussed at stand-up

@prwolfe
Copy link
Contributor

prwolfe commented Feb 22, 2021

Looks like this failure is related to the commit 5262096. Essentially the added CXX_FLAGS set up a flag for the mvcc_wrapper that xlC does not understand. By experiment it looks like we need

-qxflag=disable__cplusplusOverride

for both builds and

-ccbin xlc++

only for the cuda build.

prwolfe added a commit to prwolfe/Trilinos that referenced this issue Feb 22, 2021
Basically the added c++14 flags for xl (-qxflag=disable__cplusplusOverride)
and the nvcc_wrapper flag needed to allow that (-ccbin xlc++)
need to be split.
trilinos-autotester added a commit that referenced this issue Mar 10, 2021
Automatically Merged using Trilinos Pull Request AutoTester
PR Title: This will resolve #8756  by changing CXX_FLAGS
PR Author: prwolfe
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Mar 11, 2021
…s:develop' (8d5b058).

* trilinos-develop:
  Intrepid2: UVM-free MonolothicExecutable Tests (trilinos#8852)
  Piro: add 'Optimizer Iteration Number' to Piro_ThyraProductME
  tpetra:  trilinos#8794 trilinos#8804  test to pick threshold timed out in PR testing. Lowering the upper bound of testing to fit run into PR testing time. Threshold is close to 400, so lowering upper bound of testing should be OK.
  Piro: move the Enable Explicit Matrix Transpose option to the app parameter list
  Piro: print response even for iteration 0
  std: -> std::
  Piro: print ROL headers
  Piro: Use observer to observe the response, the solution, and the parameters
  Piro: Add ThyraProductME_Constraint and Objective
  Tempus: Add Doxygen to SolutionHistory Functions.
  Piro: add the 'Enable Explicit Matrix Transpose' option to Piro_SteadyStateSolver_Def.hpp
  Tempus: Remove ParameterList from SolutionHistory
  tpetra:  better test for PR trilinos#8804 for trilinos#8794; insert indices in batches with duplicates
  tpetra:  bug fix in PR trilinos#8804 for trilinos#8794 next commit will have enhanced test
  tpetra:  increase size of problem so that new code is actually triggered trilinos#8794
  tpetra:  added hash lookup when searching indices of dense rows trilinos#8794 tpetra:  put test into Teuchos test harness trilinos#8794 tpetra:  removed untested, unused function tpetra:  added comments trilinos#8794 tpetra:  small test to determine appropriate threshold for trilinos#8794
  This will resolve trilinos#8756  by changing CXX_FLAGS
@prwolfe
Copy link
Contributor

prwolfe commented Mar 15, 2021

This is resolved. We are seeing other build failures which will be tracked separately.

@prwolfe prwolfe closed this as completed Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ATDM Sev: Critical Problems that critically damage ability to run ATDM Trilinos builds much less allow APP updates impacting: configure or build The issue is primarily related to configuring or building PA: Framework Issues that fall under the Trilinos Framework Product Area pkg: ForTrilinos Primary Build Added by triager to mark failures affecting primary builds type: bug The primary issue is a bug in Trilinos code or tests
Projects
None yet
Development

No branches or pull requests

3 participants