Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Trilinos default to ETI=ON #8130

Closed
jwillenbring opened this issue Sep 30, 2020 · 9 comments
Closed

Change Trilinos default to ETI=ON #8130

jwillenbring opened this issue Sep 30, 2020 · 9 comments
Assignees
@ZUUL42
Labels
type: enhancement Issue is an enhancement, not a bug

Comments

@jwillenbring
Copy link
Member

Enhancement

@trilinos/framework

CC: @kddevin @rppawlo @ccober6 @srajama1 @maherou @mperego

We have decided to move forward with changing the default for Trilinos to ETI=ON. We need to decide when and how. How much notice do we provide? Do we wait for a major version of Trilinos? (We seem to be leaning towards no).

Most, if not nearly all, customers already explicitly turn ETI to ON.
@jwillenbring jwillenbring added the type: enhancement Issue is an enhancement, not a bug label Sep 30, 2020
@jwillenbring jwillenbring self-assigned this Sep 30, 2020
@kddevin
Copy link
Contributor

kddevin commented Sep 30, 2020

There's no need to wait for a major version release; is there a minor release coming soon?
Can we just advertise in mailing lists, SART meetings, etc., for a few weeks and then do it?

@jwillenbring
Copy link
Member Author

There is not a specific date chosen for a minor release, but we had tentatively planned one for this fall. We could target, for example, Oct 27 if people think that would be a good day to branch. I am open to later than that too. I don't want to go a lot sooner, just because we tend to provide people with some notice. Also, just getting onto develop is not sufficient for people to get their changes in, the dev->master promotion also has to happen for any changes included in the release, so I want to allow a little time for that in case there is a hiccup in that process.

@jwillenbring jwillenbring assigned ZUUL42 and unassigned jwillenbring Oct 28, 2020
@jwillenbring
Copy link
Member Author

There is now a PR up for this. See #8333

@prwolfe
Copy link
Contributor

prwolfe commented Nov 12, 2020

There is now a PR up for this. See #8333

The PR was moved to TriBITSPub/TriBITS#336 per the authors request.

@bartlettroscoe
Copy link
Member

FYI: This is a duplicate of #361 from 4.5 years ago.

I will update the PR TriBITSPub/TriBITS#336 to fix the documentation and edit the commit message to point back to this issue. I will post a Trilinos PR with an updated TriBITS snapshot with this change.

Thanks for finally agreeing to make this change!

@bartlettroscoe bartlettroscoe mentioned this issue Nov 12, 2020
Closed
bartlettroscoe pushed a commit to prwolfe/TriBITS that referenced this issue Nov 12, 2020
@prwolfe @bartlettroscoe
Change the default for <Project>_ENABLE_EXPLICIT_INSTANTIATION to ON
2418f31 
This was motivated by Trilinos as it improves the build and link time somewhat
(see trilinos/Trilinos#8130).
bartlettroscoe added a commit to prwolfe/TriBITS that referenced this issue Nov 12, 2020
@bartlettroscoe
Update documentation and release notes for change in ETI default to ON (
1261ef9 
trilinos/Trilinos#8130)

See the updated documentation and notes for details.
bartlettroscoe added a commit to TriBITSPub/TriBITS that referenced this issue Nov 12, 2020
@bartlettroscoe
Merge branch 'ETI_default_to_on' (trilinos/Trilinos#8130)
5e674ad 
Build/Test Cases Summary
Enabled Packages:
Enabled all Packages
0) MPI_DEBUG => passed: passed=387,notpassed=0 (1.38 min)
1) SERIAL_RELEASE => passed: passed=387,notpassed=0 (1.51 min)
2) MPI_DEBUG_CMake-3.17.0 => passed: passed=392,notpassed=0 (1.53 min)
3) SERIAL_RELEASE_CMake-3.17.0 => passed: passed=392,notpassed=0 (1.39 min)
Other local commits for this build/test group: 1261ef9, 2418f31
bartlettroscoe added a commit that referenced this issue Nov 12, 2020
@bartlettroscoe
Automatic snapshot commit from tribits at 1261ef9
123749e 
Origin repo remote tracking branch: 'github/master'
Origin repo remote repo URL: 'github = git@github.com:TriBITSPub/TriBITS.git'

At commit:

commit 1261ef96c484f7879be2d0196b6802a0115aeb96
Author:  Roscoe A. Bartlett <rabartl@sandia.gov>
Date:    Thu Nov 12 09:50:42 2020 -0700
Summary: Update documentation and release notes for change in ETI default to ON (#8130)
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this issue Nov 12, 2020
@bartlettroscoe
Merge branch 'tribits_github_snapshot' into 8130-eti-on (trilinos#8130)
977d166
@bartlettroscoe
Copy link
Member

The new Trilinos PR is #8340. Please approve so it will get merged. And thanks again!

trilinos-autotester added a commit that referenced this issue Nov 13, 2020
@trilinos-autotester
Merge Pull Request #8340 from bartlettroscoe/Trilinos/8130-eti-on
eac6296 
Automatically Merged using Trilinos Pull Request AutoTester
PR Title: Change Trilinos/TriBITS default of ETI to ON (#8130)
PR Author: bartlettroscoe
@bartlettroscoe bartlettroscoe mentioned this issue Nov 13, 2020
Merged
@bartlettroscoe
Copy link
Member

bartlettroscoe commented Nov 13, 2020 •
edited
Loading

With the merge of #8340, this should now be complete.

@jwillenbring
Copy link
Member Author

As Ross said, this can be closed.

@bartlettroscoe
Copy link
Member

Related to:

  • SEPW-213

@gassmoeller gassmoeller mentioned this issue Jul 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZUUL42 ZUUL42

Labels
type: enhancement Issue is an enhancement, not a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bartlettroscoe @jwillenbring @prwolfe @kddevin @ZUUL42