-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial adjustment of Primary Tested set of Trilinos Packages and TPLs #410
Comments
I just sent an email to internal SNL customers of Trilinos in order to try to gather up the list of important Trilinos packages. Unfortunately, I can't include those emails here because they name specific SNL codes. But I will gather up the final list in this Issue ticket. |
NOTE: I just created the internal SON ticket: to process the list of "important" packages and TPLs for internal SNL customers. The outcome from that story will be an updated candidate list of PT packages and TPLs. |
I completed the analysis of the Trilinos packages, SE package, and TPLs used by a bunch of Trilinos customers and created a combined list from all of these. You can see what customers were considered and where the data came from by looking at: The combined list sorted alphabetically is given below. The challenge that we face is that large set of TPLs that all of our Trilinos customers are using:
The problem is that the SEMS env can only provide the TPLs:
What is missing from SEMS is:
Not much we can do about that if we are going to build our CI system on the SEMS env. It has what it has. I am going to put this story into review now and move on with #482. @trilinos/framework, any comments on this? Full set of packages: Amesos Amesos2 Anasazi AztecOO Belos Claps Domi Drekar DrekarMHD Epetra EpetraExt FEI Galeri GlobiPack Gtest Ifpack Ifpack2 Intrepid Intrepid2 Isorropia Kokkos Mesquite ML MOOCHO MueLu NOX OptiPack Pamgen Panzer Phalanx Pike Piro ROL RTOp Rythmos Sacado SEACAS Shards ShyLU STK Stokhos Stratimikos Teko Teuchos ThreadPool Thyra Tpetra TriKota TrilinosCouplings Triutils Xpetra Zoltan Zoltan2 Full set of SE packages: Amesos Amesos2 Anasazi AztecOO Belos Claps Domi Drekar DrekarMHD Epetra EpetraExt FEI Galeri GlobiPack Gtest Ifpack Ifpack2 Intrepid Intrepid2 IntrepidCore Isorropia Kokkos KokkosAlgorithms KokkosContainers KokkosCore KokkosTPL Mesquite ML MOOCHO MueLu NOX OptiPack Pamgen Panzer PanzerAdaptersSTK PanzerCore PanzerDiscFE PanzerDofMgr Phalanx Pike PikeBlackBox PikeImplicit Piro ROL RTOp Rythmos Sacado SEACAS SEACASAlgebra SEACASAprepro SEACASAprepro_lib SEACASBlot SEACASChaco SEACASConjoin SEACASEjoin SEACASEpu SEACASEx1ex2v2 SEACASEx2ex1v2 SEACASExo_format SEACASExodiff SEACASExodus SEACASExodus_for SEACASExoIIv2for32 SEACASExomatlab SEACASExotxt SEACASFastq SEACASGen3D SEACASGenshell SEACASGjoin SEACASGrepos SEACASGrope SEACASIoss SEACASMapvar SEACASMapvar-kd SEACASMapvarlib SEACASNemesis SEACASNemslice SEACASNemspread SEACASNumbers SEACASPLT SEACASSupes SEACASSuplib SEACASSuplibC SEACASSuplibCpp SEACASSVDI SEACASTxtexo Shards ShyLU ShyLUCore STK STKClassic STKDoc_tests STKExprEval STKIO STKMesh STKSearch STKSearchUtil STKTopology STKTransfer STKUnit_test_utils STKUnit_tests STKUtil Stokhos Stratimikos Teko Teuchos TeuchosComm TeuchosCore TeuchosKokkosComm TeuchosKokkosCompat TeuchosNumerics TeuchosParameterList TeuchosRemainder ThreadPool Thyra ThyraCore ThyraEpetraAdapters ThyraEpetraExtAdapters ThyraTpetraAdapters Tpetra TpetraClassic TpetraCore TpetraKernels TpetraTSQR TriKota TrilinosCouplings Triutils Xpetra Zoltan Zoltan2 Full set of TPLs: AMD BLACS BLAS Boost BoostLib DLlib HDF5 LAPACK METIS MPI MUMPS Netcdf PARDISO_MKL ParMETIS PETSC Pthread QT SCALAPACK SuperLU SuperLUDist UMFPACK X11 y12m Zlib |
I see Scotch is missing. |
That is interesting. Looks like none of the internal Trilinos customers that responded to my request are using Scotch with Trilinos. You can see the full set of customers that were considered in: But also note that the SEMS env only provides a 32-bit build for Scotch which is in-compatible with the 64-bit version they provide for ParMETIS. You can read about that in #475. |
Scotch is a recent addition. SIERRA officially started testing it late September, if my memory is right. |
Good to know, thanks. I did a search of the SEMS JIRA project and I found: that suggests that SEMS might now provide a compatible 64-bit version of Scotch. Can anyone confirm that? @kddevin, have you been able to test out the SEMS env with 64-bit ParMETIS and Scotch both enabled with Zoltan and Zoltan2? |
Is there a 32-bit version. Tacho works with 32-bit. We can add a 64-bit version interface as well. |
The problem is that you can't enabled both the 64-bit version of ParMETIS and the 32-bit version of Scotch at the same time. If you do, a bunch of Zoltan and Zoltan2 tests fail. That is no good. |
Tacho does not require for 32 bit version specifically. Does SIERRA use a 32 bit version ? |
|
@kddevin, has anyone tried this with the ParMETIS and Scotch TPLs provided by the SEMS Env? If not, we can try this later once we get #482 done. Adding more TPLs to our CI and Nightly testing is something that we will need to do gradually as we can. (We just need infrastructure manpower to help with this). If you look at the list of TPLs that are actually used by our important Sandia Trilinos customers listed above, you will see that we are falling far short with what Trilinos is currently testing in Nightly builds and what is provided by the SEMS env. |
@bartlettroscoe I don't understand. What is "this" in your question above? |
Sorry, I should have been more explicit. Has any Zoltan or Zoltan2 developer tried the updated SEMS-provided 64-bit Scotch and ParMETIS TPLs? It looks like these are now present under:
If not, that is fine. I was just asking. |
Yes; see my comment 2 above. All tested. All good. Thanks. |
Realized that we need to make a few changes to the list of packages and SE packages listed above. First, Second, I accidentally listed Third, Forth, So taking out
|
I changed this while looking to make sure the Tpetra packages were declared correctly.
Several packages were added to PT and a few were removed according what is being used by important Trilinos customers (see trilinos#410 and trilinos#482). Also, several TPLs were added to the set of PT TPLs. These are the TPLs that are used by important Trilinos customers (see trilinos#410) and are also provided by the SEMS env.
Another adjustment needs to be made. The subpackage
CASL VERA is using very old version of Intrepid before this commit was made. Removing
|
Another change to the list of SE packages. Seems that Kokkos no longer has a subpackage called "KokkosTPL". It was removed in this commit:
Only one Trilinos customer listed that (you can see which one by examining the combined_list_of_trlinos_customer_enables.sh script in TRIL-59). That customer must have been using a very old version of Trilinos when they reported this. The update list of enables removing
|
I went back and put the script Here is the updated list of PT enables:
|
Since Panzer has been elivated to PT and since important Trilinos customers are using these subpackages, they must be elevated to PT. See trilinos#410 and trilinos#482 for more details.
I changed this while looking to make sure the Tpetra packages were declared correctly.
Several packages were added to PT and a few were removed according what is being used by important Trilinos customers (see trilinos#410 and trilinos#482). Also, several TPLs were added to the set of PT TPLs. These are the TPLs that are used by important Trilinos customers (see trilinos#410) and are also provided by the SEMS env.
This is being used by an important Trilinos customer (see trilinos#410 and TRIL-59) and therefore should be tested in pre-push CI testing.
Since Pike has been elevated to PT so must its subpackages that are used by an important Trilinos customer (CASL VERA in this case).
Since SEACAS has been elevated to PT and since important Trilinos customers are using these subpackages, they must be elevated to PT. See trilinos#410 and trilinos#482 for more details.
Since STK has been elivated to PT and since important Trilinos customers are using these subpackages, they must be elevated to PT. See trilinos#410 and trilinos#482 for more details.
Since Panzer has been elivated to PT and since important Trilinos customers are using these subpackages, they must be elevated to PT. See trilinos#410 and trilinos#482 for more details.
…/Trilinos#410) These are the subpackage of SEACAS that are used by Trilinos customers and therefore have been elevated to Primary Test (PT) for Trilinos (see trilinos/Trilinos#410). I also replaced the deprecated test category 'SS' (Secondary Stable) with 'ST' (Secondary Tested). This is a duplicate of the direct Trilinos SEACAS commit: 8057316 "SEACAS: Elevate many subpackages to PT (sandialabs#410, sandialabs#482)" Author: Roscoe A. Bartlett <rabartl@sandia.gov> Date: Thu Nov 10 08:05:06 2016 -0700 (24 hours ago) M packages/seacas/cmake/Dependencies.cmake Therefore, that commit will need to be reverted (using 'git revert 8057316') before snapshotting an updated version of SEACAS into Trilinos. See the Trilinos issues: * trilinos/Trilinos#410 * trilinos/Trilinos#482
…/Trilinos#410) These are the subpackage of SEACAS that are used by Trilinos customers and therefore have been elevated to Primary Test (PT) for Trilinos (see trilinos/Trilinos#410). I manually verified that this gives the right set of PT packages by configuring Trilinos with this version of the SEACAS package. (That is, I cloned the seacas repo under Trilinos then configured Trilinos with -DSEACAS_SOURCE_DIR_OVERRIDE:STRING=seacas/packages/seacas). I also replaced the deprecated test category 'SS' (Secondary Stable) with 'ST' (Secondary Tested). This is a duplicate of the direct Trilinos SEACAS commit: 8057316 "SEACAS: Elevate many subpackages to PT (sandialabs#410, sandialabs#482)" Author: Roscoe A. Bartlett <rabartl@sandia.gov> Date: Thu Nov 10 08:05:06 2016 -0700 (24 hours ago) M packages/seacas/cmake/Dependencies.cmake Therefore, that commit will need to be reverted (using 'git revert 8057316') before snapshotting an updated version of SEACAS into Trilinos (or updating Trilinos in that other application code that snapshots Trilinos+SEACAS that also owns the STK source that I can't mention). See the Trilinos issues: * trilinos/Trilinos#410 * trilinos/Trilinos#482
CONFIG: Elevate many subpackages to PT for Trilinos testing (trilinos/Trilinos#410)
This is complete and is being used in new CI build. It is unlikely that anyone will seriously review this so closing as complete. Also, we are no longer going to purse extending the checkin-test-sems.sh (or checkin-test.py) script for Trilinos (see #482 (comment)). No idea what selection of packages and TPLs will be used for new automatic PR system but that can be determined later by someone else. |
Next Action Status:
Sent email to SNL customers of Trilinos, asking for list of Trilinos packages and TPLs. Next: Wait for responses ...
CC: @jwillenbring, @bmpersc, @maherou, @trilinos/framework
Blocked By: #158
Blocking: #370
Description:
This story is to do an initial adjustment (mostly an extension) the set of Primary Tested (PT) TPLs to include HDF5, Netcdf, Boost, SWIG and any others needed to fully build and test packages like SEACAS, STK, etc. This initial set of packages and TPLs will be limited to what is provided by the SEMS Dev Env (see #158). Otherwise, some packages that could be included based on that set of TPLs should otherwise be excluded from the set of PT packages as guided by the needs of important Trilinos customers and critical research efforts (which are need to be well protected). Purely exploratory software or packages without important current users uses should generally be excluded from the PT set (to speed up the builds and tests). Also, non-critical configurations (e.g. complex, float) should be avoided to speed up builds and testing.
This initial story will be to support the usage of the checkin-test.py script to update from the 'develop' to the 'master' branch (see #370).
Tasks:
The text was updated successfully, but these errors were encountered: