Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL Parser Performance #731

Merged
merged 6 commits into from
Aug 13, 2024
Merged

Conversation

jranson
Copy link
Member

@jranson jranson commented Aug 13, 2024

This patch improves the SQL Lexer/Parser performance by refactoring from the previous scheme of concurrent lexing/parsing via channels to a lex-then-parse scheme that is more performant due to a 100% removal of channels in the request path.

Signed-off-by: James Ranson <james@ranson.org>
Signed-off-by: James Ranson <james@ranson.org>
Signed-off-by: James Ranson <james@ranson.org>
Signed-off-by: James Ranson <james@ranson.org>
Signed-off-by: James Ranson <james@ranson.org>
Signed-off-by: James Ranson <james@ranson.org>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10374393449

Details

  • 31 of 32 (96.88%) changed or added relevant lines in 6 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 88.992%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/parsing/run_state.go 8 9 88.89%
Files with Coverage Reduction New Missed Lines %
pkg/parsing/run_state.go 1 97.62%
pkg/cache/bbolt/bbolt.go 4 88.55%
Totals Coverage Status
Change from base Build 9143081403: -0.02%
Covered Lines: 17681
Relevant Lines: 19868

💛 - Coveralls

Copy link
Contributor

@LimitlessEarth LimitlessEarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. This is my favorite kind of PR.

@jranson jranson merged commit 65513a4 into trickstercache:main Aug 13, 2024
5 checks passed
@jranson jranson deleted the sql-parser-perf branch August 13, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants