[SYCL][Runtime] Inversing the ARM Defines to fix Intel CPU #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made a mistake and also pull requested before all the tests were complete... the #if defines were the incorrect way around for throwing errors. So it would throw runtime errors on intel rather than for arm!
|
Thanks. |
Ralender
pushed a commit
to Ralender/sycl
that referenced
this pull request
Jul 1, 2020
|
FYI intel/llvm#2333 shows how to solve the cache (line) size queries with |
|
So you mean that our special case is no longer required once merged with SYCL upstream? |
|
Honestly, I don't know why the SYCL runtime needs to know any of that stuff, but I'm not going to worry about it right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a small mistake and also pull requested before all the tests were
complete... the #if defines were the incorrect way around for throwing
errors. So it would throw runtime errors on intel rather than for arm!
Sorry, silly mistake, I should be more careful..