Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Built-in type declarations #30

Closed
1 task done
marconms opened this issue Jan 12, 2022 · 4 comments · Fixed by #33
Closed
1 task done

Built-in type declarations #30

marconms opened this issue Jan 12, 2022 · 4 comments · Fixed by #33
Assignees
@trezy
Labels
released type: bug Something isn't working type: documentation Improvements or additions to documentation

Comments

@marconms
Copy link
Contributor

marconms commented Jan 12, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.

The first time I encountered the package, I expected to use it with built-in type declarations.

Describe the solution you'd like

It would be nice to see declarations added.

Describe alternatives you've considered

There's no real alternatives for implementing Typescript types 😅

Additional context

The creation of a simple types.d.ts would suffice, it should be quick to implement while keeping JavaScript as the main language.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@marconms marconms added needs: triage Waiting for a contributor to triage type: feature New feature or request labels Jan 12, 2022
@trezy
Copy link
Owner

trezy commented Jan 12, 2022

Hmm... tsd-jsdoc should be generating types with the published package. I'll look into this and see what I can figure out.

@trezy trezy added type: bug Something isn't working type: documentation Improvements or additions to documentation and removed type: feature New feature or request needs: triage Waiting for a contributor to triage labels Jan 12, 2022
@marconms
Copy link
Contributor Author

Right, double-checking in the NPM page, it does seem to contain type declarations; they don't show up for me, though.
I'll investigate a bit more, it may be just a problem from my end, I didn't realize.

@trezy
Copy link
Owner

trezy commented Jan 12, 2022

Installing the latest version of the lib, I'm not actually getting the types. As it turns out, I created the build-types Yarn script, but I never actually implemented it for the release. 🤦🏻‍♂️

I'll get this fixed here shortly.

trezy added a commit that referenced this issue Jan 12, 2022
@trezy
fix(types): add type construction to publishing pipeline
d55a33f 
fixes #30
@trezy trezy mentioned this issue Jan 12, 2022
Merged
@trezy trezy closed this as completed in #33 Jan 12, 2022
@github-actions
Copy link

🎉 This issue has been resolved in version 3.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trezy trezy

Labels
released type: bug Something isn't working type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing types declaration file trezy/next-safe
2 participants
@trezy @marconms