Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use png(type="cairo") in vignette example to avoid UBSAN warning on CRAN #132

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

trevorld
Copy link
Owner

  • In "noise" vignette save images with png(type="cairo") to avoid UBSAN warning on CRAN being raised in {ragg}
  • Tweak examples to use linewidth instead of deprecated size

closes #131

* Updated a couple of examples to use the `linewidth` aesthetic
  instead of the `size` aesthetic which was deprecated in `{ggplot2}` 3.4.0.
* In "noise" vignette save images with `png(type="cairo")`
  when not in `{pkgdown}` to avoid triggering a UBSAN issue
  in {ragg} when checked on CRAN

closes #131
@trevorld trevorld merged commit 22a689f into master Jan 28, 2025
3 checks passed
@trevorld trevorld deleted the issue131 branch January 28, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gcc-UBSAN warning in a package {ggpattern} suggests
1 participant