Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vignette improvements #116

Merged
merged 4 commits into from
Apr 20, 2024
Merged

Vignette improvements #116

merged 4 commits into from
Apr 20, 2024

Conversation

trevorld
Copy link
Owner

@trevorld trevorld commented Apr 19, 2024

  • In gganimate.Rmd we now save {gganimate} animation with gganimate::anim_save() instead of trying to save and view animation with {knitr} hook. This avoids an error due to an upstream bug.
  • Add vignettes/precompute_vignettes.R to version control

progress on #114
closes #108

* In `gganimate.Rmd` we now save {gganimate} animation
  with `gganimate::anim_save()` instead of trying
  to save and view animation with {knitr} hook.
* This avoids an error due to an upstream bug.

closes #108
* Previously overlooked to to `.gitignore` policy in `vignettes` folder.

progress on #114
* Vignette links now point to to `trevorldavis.com/R/ggpattern/dev`
* GH repo references now refer to `trevorld/ggpattern`
* Suppress package loading/startup messages
* Remove a couple deprecation warnings
* Remove "kitten" placeholder examples which currently don't work
* Suppress some figure captions
@trevorld trevorld force-pushed the improve-vignettes-114 branch from 88e4da1 to eaf1a38 Compare April 20, 2024 04:18
@trevorld trevorld merged commit 2afcc30 into master Apr 20, 2024
2 checks passed
@trevorld trevorld deleted the improve-vignettes-114 branch April 20, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

{gganimate} example vignette animation doesn't show in {pkgdown} site
1 participant