v1.1 #10
Merged
v1.1 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denar90
reviewed
Sep 11, 2019
| */ | ||
|
|
||
| exports.getCruxData = async (artifacts, context) => { | ||
| exports.getLoadingExperience = async (artifacts, context, isUrl = true) => { |
| @@ -39,7 +30,7 @@ serial('Measure field perf for site in CruX', async t => { | |||
|
|
|||
| serial('Measure field perf for site site not in CruX', async t => { | |||
| const resName = 'not-in-field.json' | |||
| await runLighthouse('https://example.com/', { ...lhOptions, outputPath: `./results/${resName}` }) | |||
| await runLighthouse('https://alekseykulikov.com/', { ...lhOptions, outputPath: `./results/${resName}` }) | |||
There was a problem hiding this comment.
Do you think results always will be stable on Field and match snapshot? Our intention to stub PSI response to not update snapshot for each new CI run or PSI cache invalidation hence new perf measurements of the site.
alekseykulikov
force-pushed
the
1_1
branch
3 times, most recently
from
5cd1ce8 to
9c7ce6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks: