Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop depending on dtrace provider #60

Closed
domenic opened this issue Nov 20, 2012 · 10 comments
Closed

Stop depending on dtrace provider #60

domenic opened this issue Nov 20, 2012 · 10 comments

Comments

@domenic
Copy link

domenic commented Nov 20, 2012

We were using this package great on Windows and Linux in the 0.10 timeframe; now we can't install it.

@trentm
Copy link
Owner

trentm commented Nov 20, 2012

What does an 'npm install' look like (can you quote the shell session)? Crazily I don't have access to a Linux or Windows box handy right now.

@domenic
Copy link
Author

domenic commented Nov 20, 2012

Crazily I don't have a working copy of node-gyp handy right now O_o. Will get you some logs when I get home. It's possible I was assuming the problem was dtrace-provider when really it's any native module on my systems.

@trentm
Copy link
Owner

trentm commented Nov 20, 2012

Thanks. My understanding is that node-dtrace-provider properly stubs out for non-dtrace'ing platforms and will install on Linux and Windows. So I'd first like to make sure that isn't the problem.

Orthogonal to that: Make dtrace-provider a required dep was an intentional decision to not have Bunyan dtrace support silently NOT work for a user. If dtrace-provider were an "optionalDependency" then an "npm install" failure for it would be silent. "bunyan.js" will work without dtrace-provider, it just won't have the dtrace support. I'm not entirely happy with the current state because having Bunyan install depend on a binary module with a complex-enough build that it is much less reliable.... sucks. This is far from the first ticket bringing up dtrace-provider install issues hitting Bunyan.

@domenic
Copy link
Author

domenic commented Nov 21, 2012

Yup, sorry, false alarm.

@domenic domenic closed this as completed Nov 21, 2012
@matthiasg
Copy link

this is still an issue when you want to install bunyan as a tool on a machine without a compiler (read all windows servers in production). The way it is now, we have to install it on a dev machine and then copy it over ... not quite ideal.

@trentm
Copy link
Owner

trentm commented Jan 18, 2013

@matthiasg I've opened issue #66 for this. I'll look into seeing if I can get dtrace-provider to not bork if the deps for binary modules aren't available.

@matthiasg
Copy link

Sounds good ! Thanks.


From: Trent Mick
Sent: 18.01.2013 20:03
To: trentm/node-bunyan
Cc: Matthias Götzke
Subject: Re: [node-bunyan] Stop depending on dtrace provider (#60)

@matthiasghttps://github.com/matthiasg I've opened issue #66#66 for this. I'll look into seeing if I can get dtrace-provider to not bork if the deps for binary modules aren't available.


Reply to this email directly or view it on GitHubhttps://github.com//issues/60#issuecomment-12436231.

@mbana
Copy link

mbana commented Jul 31, 2018

has this been fixed?

@Floby
Copy link

Floby commented Feb 21, 2019

nope.

@bruce-lindsay
Copy link

I found this to be helpful after being stuck on this problem for a bit.
https://www.npmjs.com/package/bunyan-sfdx-no-dtrace

bruce-lindsay added a commit to bruce-lindsay/probot that referenced this issue Jan 30, 2020
bruce-lindsay added a commit to bruce-lindsay/probot that referenced this issue Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants