Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to rust 1.52 #1003

Merged
merged 9 commits into from
May 17, 2021
Merged

Update to rust 1.52 #1003

merged 9 commits into from
May 17, 2021

Conversation

Licenser
Copy link
Member

Pull request

Description

rust and tarpaulin update

Related

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

rust version update

@coveralls
Copy link
Collaborator

coveralls commented May 11, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 83.846% when pulling 0bccbf2 on rust-1.52.1 into 42237c5 on main.

@Licenser Licenser force-pushed the rust-1.52.1 branch 3 times, most recently from 03026f4 to 36aba23 Compare May 12, 2021 10:06
@Licenser
Copy link
Member Author

The coverage drop in this is caused by a degradation in tarpaulin with version 0.18.0-alpha3 the related ticket is here: xd009642/tarpaulin#757

Licenser added 6 commits May 17, 2021 13:02
@Licenser
Update to rust 1.52
b447875 
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
@Licenser
Some coverage recoverage
b74694e 
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
@Licenser
Add coverage for match clauses
30c6f4a 
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
@Licenser
cleanup preprocess
48b0f9d 
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
@Licenser
Obey Clippy
1b7ed38 
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
@Licenser
more cleanup in lexer
c792eb9 
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
@Licenser Licenser force-pushed the rust-1.52.1 branch 2 times, most recently from 2afb18d to 7504ada Compare May 17, 2021 12:48
@Licenser
Better coverage for aggregate functions
429511f 
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
@Licenser
Improve coverage for raw
0407337 
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
mfelsche
mfelsche approved these changes May 17, 2021
View reviewed changes
Copy link
Member

@mfelsche mfelsche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gods of coverage accept your sacrifice!

@Licenser Licenser merged commit 1046098 into main May 17, 2021
@Licenser Licenser deleted the rust-1.52.1 branch May 17, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfelsche mfelsche mfelsche approved these changes

@anupdhml anupdhml Awaiting requested review from anupdhml

@darach darach Awaiting requested review from darach darach is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[tracking] update to rust 1.52.0
3 participants
@Licenser @coveralls @mfelsche