Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To install tremor-language-server 0.8.1 from crates.io, users have to configure cpu target as per https://github.com/simd-lite/simd-json#cpu-target (for the simd-json dependency that comes via tremor-script currently).
Example:
Needed configuration is there in the project
.cargo
:https://github.com/wayfair-tremor/tremor-language-server/blob/v0.8.1/.cargo/config
But this file is not read during
cargo install
so it only works for builds straight from the git repo.To simplify the installation process, this MR opts to use simd-json with
allow-non-simd
feature. Ease of installation is more important for tremor-language-server than json processing performance so this should be fine to do.We had similar behavior in v0.7.4 but it got removed as part of 0.8 release here: c45b23c
Now we specify simd-json only as build-dependency. If we choose to add a
allow-non-simd
feature to tremor-script (pointing to the simd-json feature of the same name), we can revisit this MR (that might be better than adding a simd-json dependency here, which is not really used directly in trill).Verified as working via: