Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify cargo installation #49

Merged
merged 2 commits into from
May 14, 2020
Merged

Simplify cargo installation #49

merged 2 commits into from
May 14, 2020

Conversation

anupdhml
Copy link
Contributor

@anupdhml anupdhml commented May 14, 2020

To install tremor-language-server 0.8.1 from crates.io, users have to configure cpu target as per https://github.com/simd-lite/simd-json#cpu-target (for the simd-json dependency that comes via tremor-script currently).

Example:

RUSTFLAGS="-C target-cpu=native" cargo install tremor-language-server

Needed configuration is there in the project .cargo:
https://github.com/wayfair-tremor/tremor-language-server/blob/v0.8.1/.cargo/config

But this file is not read during cargo install so it only works for builds straight from the git repo.

To simplify the installation process, this MR opts to use simd-json with allow-non-simd feature. Ease of installation is more important for tremor-language-server than json processing performance so this should be fine to do.


We had similar behavior in v0.7.4 but it got removed as part of 0.8 release here: c45b23c

Now we specify simd-json only as build-dependency. If we choose to add a allow-non-simd feature to tremor-script (pointing to the simd-json feature of the same name), we can revisit this MR (that might be better than adding a simd-json dependency here, which is not really used directly in trill).


Verified as working via:

cargo install --git https://github.com/wayfair-tremor/tremor-language-server.git --branch simplify_cargo_install

@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #49 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #49   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           7       7           
  Lines         296     296           
======================================
  Misses        296     296           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 438add7...7f5e336. Read the comment docs.

Copy link
Member

@darach darach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darach darach merged commit f668816 into master May 14, 2020
@darach darach deleted the simplify_cargo_install branch May 14, 2020 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants