Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Requests" and "StringIO" is not needed #5

Open
ichthyosaurus opened this issue Oct 25, 2020 · 3 comments
Open

"Requests" and "StringIO" is not needed #5

ichthyosaurus opened this issue Oct 25, 2020 · 3 comments

Comments

@ichthyosaurus
Copy link

You can directly fetch the url in lyrics.py with lxml:

doc = lxml.html.parse(url)

This way you don't need StringIO (which is not in py3), and neither requests.

But LyricsWiki is gone anyway...

@tremby
Copy link
Owner

tremby commented Oct 25, 2020

I didn't even realize... According to Wikipedia it disappeared about a month ago.

Thanks for pointing out that those two libraries are not needed, but as you say I guess it's moot now.

@ichthyosaurus
Copy link
Author

ichthyosaurus commented Oct 26, 2020

But maybe the script could be changed to use a new provider... It would need a bit of research to find one with a similarly simple way to access. Also there's a backup on archive.org: maybe someone will host LyricWiki again.

@ronilaukkarinen
Copy link

Just noticed this. Too bad. I loved py-lyrics... :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants