Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebAC filter does not respect baseURL override #382

Closed
acoburn opened this issue Apr 3, 2019 · 1 comment
Closed

WebAC filter does not respect baseURL override #382

acoburn opened this issue Apr 3, 2019 · 1 comment
Assignees
Labels
area/http HTTP module bug
Milestone

Comments

@acoburn
Copy link
Member

acoburn commented Apr 3, 2019

As reported on the Trellis email list by @mjgiarlo, when a custom baseURL is in use, the WebAC filter does not take this into consideration when generating a link header in the response. For example, with a custom base url of http://example.com/, the response link header might contain, instead:

Link: <http://localhost/resource?ext=acl>; rel="acl"
@acoburn acoburn added bug area/http HTTP module labels Apr 3, 2019
@acoburn acoburn added this to the 0.9.0 Release milestone Apr 3, 2019
@acoburn acoburn self-assigned this Apr 3, 2019
acoburn added a commit that referenced this issue Apr 3, 2019
@mjgiarlo
Copy link

mjgiarlo commented Apr 3, 2019

You beat me to it. 🙂 Thanks, @acoburn!

acoburn added a commit that referenced this issue Apr 3, 2019
acoburn added a commit that referenced this issue Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/http HTTP module bug
Projects
None yet
Development

No branches or pull requests

2 participants