Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graveler transform catalog interface #993

Merged
merged 13 commits into from
Dec 3, 2020
Merged

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Dec 3, 2020

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 3, 2020

Codecov Report

Merging #993 (9c74846) into master (18bf790) will decrease coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #993      +/-   ##
==========================================
- Coverage   44.60%   44.27%   -0.33%     
==========================================
  Files         142      140       -2     
  Lines       11587    11570      -17     
==========================================
- Hits         5168     5123      -45     
- Misses       5765     5798      +33     
+ Partials      654      649       -5     
Impacted Files Coverage Δ
catalog/mvcc/validate.go 88.23% <0.00%> (-6.21%) ⬇️
catalog/mvcc/cataloger_create_entry.go 94.73% <0.00%> (-5.27%) ⬇️
api/handler.go 70.83% <0.00%> (ø)
gateway/operations/base.go 0.00% <0.00%> (ø)
catalog/mvcc/cataloger_create_multipart_upload.go
catalog/mvcc/cataloger_get_multipart_upload.go
catalog/mvcc/cataloger_delete_multipart_upload.go
gateway/multiparts/tracker.go 0.00% <0.00%> (ø)
gateway/handler.go 58.78% <0.00%> (+0.22%) ⬆️
catalog/mvcc/cataloger_create_repository.go 66.66% <0.00%> (+3.70%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18bf790...9c74846. Read the comment docs.

Copy link
Contributor

@guy-har guy-har left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good,
Maybe we should consider returning iterators and not handle pagination in the catalog layer.

graveler/graveler.go Outdated Show resolved Hide resolved
graveler/graveler.go Outdated Show resolved Hide resolved
graveler/graveler.go Outdated Show resolved Hide resolved
graveler/graveler.go Show resolved Hide resolved
@nopcoder nopcoder requested review from johnnyaug and guy-har December 3, 2020 15:05
graveler/graveler.go Outdated Show resolved Hide resolved
graveler/graveler.go Outdated Show resolved Hide resolved
@johnnyaug johnnyaug merged commit b1b3858 into master Dec 3, 2020
@johnnyaug johnnyaug deleted the feature/catalog-entry-value branch December 3, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants