Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lakefs diagnostics query db version #939

Merged
merged 1 commit into from
Nov 19, 2020
Merged

lakefs diagnostics query db version #939

merged 1 commit into from
Nov 19, 2020

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Nov 19, 2020

Database information, used to get from metadata table,this change will enable us to query it directly for issues that our database migrate failed.

@nopcoder nopcoder requested a review from guy-har November 19, 2020 08:48
@nopcoder nopcoder self-assigned this Nov 19, 2020
@codecov-io
Copy link

Codecov Report

Merging #939 (1cd6d1d) into master (4526447) will decrease coverage by 0.84%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #939      +/-   ##
==========================================
- Coverage   45.00%   44.15%   -0.85%     
==========================================
  Files         143      143              
  Lines       11199    11454     +255     
==========================================
+ Hits         5040     5058      +18     
- Misses       5537     5773     +236     
- Partials      622      623       +1     
Impacted Files Coverage Δ
diagnostics/collector.go 66.27% <33.33%> (-1.20%) ⬇️
api/client.go 3.29% <0.00%> (-0.94%) ⬇️
auth/setup.go 0.00% <0.00%> (ø)
auth/service.go 36.17% <0.00%> (+0.13%) ⬆️
api/api_controller.go 38.23% <0.00%> (+0.16%) ⬆️
config/logger.go 75.00% <0.00%> (+10.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4526447...1cd6d1d. Read the comment docs.

@nopcoder nopcoder merged commit 0f3084a into master Nov 19, 2020
@nopcoder nopcoder deleted the feature/diag-db-ver branch November 19, 2020 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants