Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document export and unhide from CLI #915

Merged
merged 3 commits into from
Nov 12, 2020
Merged

Conversation

guy-har
Copy link
Contributor

@guy-har guy-har commented Nov 12, 2020

No description provided.

@guy-har guy-har requested a review from nopcoder November 12, 2020 15:01
change export command to be unhidden
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Before you pull, please change the PR title also to state that it documents export and shows (unhides) it.

ddl/000009_export_current.down.sql Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #915 (16d12e5) into master (a0178c2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #915   +/-   ##
=======================================
  Coverage   45.05%   45.05%           
=======================================
  Files         143      143           
  Lines       11170    11170           
=======================================
  Hits         5033     5033           
  Misses       5515     5515           
  Partials      622      622           
Impacted Files Coverage Δ
catalog/cataloger_create_entry.go 94.73% <0.00%> (-5.27%) ⬇️
catalog/cataloger_create_repository.go 62.96% <0.00%> (+3.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0178c2...16d12e5. Read the comment docs.

Co-authored-by: arielshaqed <ariels@treeverse.io>
@guy-har guy-har changed the title wrong name in drop type Document export and unhide from CLI Nov 12, 2020
@guy-har guy-har merged commit c6674e6 into master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants