Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACLs: Remove server usage #8126

Merged
merged 5 commits into from
Sep 4, 2024
Merged

ACLs: Remove server usage #8126

merged 5 commits into from
Sep 4, 2024

Conversation

N-o-Z
Copy link
Member

@N-o-Z N-o-Z commented Sep 3, 2024

Closes #8125

Changes:

  • UI
  • Documentation
  • Removal of development params

@N-o-Z N-o-Z added the include-changelog PR description should be included in next release changelog label Sep 3, 2024
@N-o-Z N-o-Z requested review from ozkatz, talSofer and guy-har September 3, 2024 21:58
@N-o-Z N-o-Z self-assigned this Sep 3, 2024
@N-o-Z
Copy link
Member Author

N-o-Z commented Sep 3, 2024

@ozkatz, @talSofer
Please review documentation and UI sections

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024 •
edited
Loading

♻️ PR Preview 30e935e has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

E2E Test Results - Quickstart

10 passed

ozkatz
ozkatz approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@ozkatz ozkatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

docs/security/access-control-lists.md Outdated Show resolved Hide resolved
@N-o-Z @ozkatz
Update docs/security/access-control-lists.md
636976b 
Co-authored-by: Oz Katz <oz.katz@treeverse.io>
guy-har
guy-har approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@guy-har guy-har left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@N-o-Z N-o-Z merged commit 707deb2 into master Sep 4, 2024
40 checks passed
@N-o-Z N-o-Z deleted the task/acl-remove-server-usage branch September 4, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guy-har guy-har guy-har approved these changes

@ozkatz ozkatz ozkatz approved these changes

@talSofer talSofer Awaiting requested review from talSofer

Assignees

@N-o-Z N-o-Z

Labels
include-changelog PR description should be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disconnect ACL server from lakeFS
3 participants
@N-o-Z @ozkatz @guy-har