Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Spark client panics when reading DataFrame from entire repository / storageNamespace #7955

Merged
merged 4 commits into from
Jul 4, 2024
Merged

[Bug]: Spark client panics when reading DataFrame from entire repository / storageNamespace #7955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0d470c6
fix path resolve
Isan-Rivkin Jul 3, 2024
352443f
fix fmt
Isan-Rivkin Jul 3, 2024
edfe06c
better resolving
Isan-Rivkin Jul 4, 2024
0e0de69
fix
Isan-Rivkin Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clients/spark/build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
lazy val projectVersion = "0.14.0"
lazy val projectVersion = "0.14.1"
version := projectVersion
lazy val hadoopVersion = "3.2.1"
ThisBuild / isSnapshot := false
Expand Down
6 changes: 3 additions & 3 deletions clients/spark/src/main/scala/io/treeverse/clients/LakeFSInputFormat.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,12 +243,12 @@ class LakeFSAllRangesInputFormat extends LakeFSBaseInputFormat {
if (StringUtils.isBlank(storageNamespace)) {
storageNamespace = apiClient.getStorageNamespace(repoName, StorageClientType.HadoopFS)
}
val namespaceURI = URI.create(storageNamespace)
val namespaceURI =
URI.create(if (storageNamespace.endsWith("/")) storageNamespace else storageNamespace + "/")
val fs = fileSystemGetter(namespaceURI, conf)
fs.getStatus(new Path(namespaceURI)) // Will throw an exception if namespace doesn't exist

val metadataURI =
namespaceURI.resolve(if (storageNamespace.endsWith("/")) "_lakefs" else "/_lakefs")
val metadataURI = namespaceURI.resolve("_lakefs")
val metadataPath = new Path(metadataURI)
if (!fs.exists(metadataPath)) {
return ListBuffer.empty[InputSplit].asJava
Expand Down
Loading