Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to use latest Go v1.15.2 #665

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Upgrade to use latest Go v1.15.2 #665

merged 1 commit into from
Sep 30, 2020

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Sep 27, 2020

@nopcoder nopcoder requested a review from ozkatz September 27, 2020 14:18
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking to decide on a strategy for Go version support.

@@ -1,6 +1,6 @@
module github.com/treeverse/lakefs

go 1.14
go 1.15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this. I agree that we should test also with bleading-edge Go. But it is impractical to require this version in order to compile. I would feel better about continuing to use 1.14 for a while, and commit to support 1.15 and 1.14 by running GitHub testing actions in a matrix.
WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No commit to supporting a specific version - if we will have issues with go 1.15 we can rollback the change.
Prefer to use what any contributor will get when he/she does 'brew install go'.
Addressing the current Go version in PR #674.
Can defer the upgrade but I don't have a good timeline on when it is the right time to switch, can go with always one version back - or only after X maintenance releases of the Go toolchain.

@nopcoder
Copy link
Contributor Author

I'll create an issue for document the strategy first

@arielshaqed
Copy link
Contributor

After discussing it today f2f, let's go (sorry) with this -- Go is an internal dependency, and we can move forward. Thanks!

@nopcoder nopcoder merged commit e438f84 into master Sep 30, 2020
@nopcoder nopcoder deleted the chore/go1.5 branch September 30, 2020 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants